Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: omit /healthz from INFO logging #1055

Closed
tammert opened this issue May 26, 2020 · 4 comments
Closed

Feature request: omit /healthz from INFO logging #1055

tammert opened this issue May 26, 2020 · 4 comments
Labels
feature New functionality/enhancement

Comments

@tammert
Copy link
Contributor

tammert commented May 26, 2020

To start off: Atlantis is awesome! Really appreciate the work you've done on it.

Problem
When running on Kubernetes, the livenessProbe/readinessProbe send a lot of requests to the /healthz endpoint, which are logged as follows:

2020/05/26 12:16:20+0000 [INFO] server: GET /healthz – respond HTTP 200
2020/05/26 12:16:36+0000 [INFO] server: GET /healthz – from <IP>
2020/05/26 12:16:36+0000 [INFO] server: GET /healthz – respond HTTP 200
2020/05/26 12:17:20+0000 [INFO] server: GET /healthz – from <IP>
2020/05/26 12:17:20+0000 [INFO] server: GET /healthz – respond HTTP 200
2020/05/26 12:17:36+0000 [INFO] server: GET /healthz – from <IP>
2020/05/26 12:17:36+0000 [INFO] server: GET /healthz – respond HTTP 200

This could be avoided by upping the log level to error, but since many interesting Atlantis/Terraform/lock logging is also info level, those would be lost too.

Proposed solution

  • It would be nice if we could use a flag to turn off the logging for certain endpoints, in this case at least for /healthz (and perhaps /events too).
  • Alternatively, those messages could be moved to debug, so we can turn them off without removing the more interesting logging.

I'm pretty sure this is not currently possible, but if it is I'd love to hear. Besides that, if you have an opinion on either of the proposed solutions (or maybe something else entirely), I'd love to hear it as I don't mind building it myself and sending a PR for this.

@lkysow lkysow added the feature New functionality/enhancement label May 26, 2020
@lkysow
Copy link
Member

lkysow commented May 26, 2020

Hey @tammert yeah I think having a solution for this would be a good idea. Should we try just moving the path logs to debug? I've asked for feedback in the Slack here: https://atlantis-community.slack.com/archives/C5MGGAV0C/p1590511701246700

@tammert
Copy link
Contributor Author

tammert commented May 26, 2020

Yea, that seems like the way to go. Pending the feedback on Slack, the PR is already up as the change was very trivial :)

@tammert
Copy link
Contributor Author

tammert commented Jun 2, 2020

@lkysow I think you can close this, as the PR has been merged and released in v0.13.0 (thanks for that, no more massive logs for us!).

@lkysow
Copy link
Member

lkysow commented Jun 2, 2020

Closed by #1056

@lkysow lkysow closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

2 participants