-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Make "No changes" stand out more + add summary of number of (un)changed projects #2069
Comments
I have a similar scenario but different view - we often have so many "No changes" modules, that the ones which actually changed are easy to overlook. I would prefer to hide the "No changes" entirely or just a have small summary instead. |
That might actually be better 👍🏻 |
It seems we are all facing the same issue, which is why I was looking at Atlantis' code last week that renders this plans and there are no current ways of doing it. The only solution I can think of is forking Atlantis and making the necessary changes. Then we could run our fork with all the things we like, and eventually contribute the changes upstream. |
And given we're taking about this: don't you also find it annoying that sometimes when there are no changes the result is something like:
And other times is:
Show output
I've found why it is inconsistent like this, and it is because of how many lines of output it has. If it's over 11 (I think) then it uses a |
Please nest the folding (
Here's the most exaggerated (but still very useful) target ... maybe a compromise is in order. Could we perhaps even template this so operators can choose a layout that suits them? This would help immensely as we sometimes have 50-100 plans in case some central lib or module changed. Overview Ran Plan for 9 projects
Details 59 to add, 24 to change, 18 to destroy.3. dir:
|
We recently merged in custom templating that could be used here to test out different templates like the ones suggested. IMHO the Github App ChecksAPI would be even better to implement so each project would get it's own page (see #936). |
Splendid.. will check it out. (We're on GitLab so am trying to abuse what's available in formatting there...). |
@nitrocode I think you're referring to #1026? |
@frimik that idea that you proposed is actually something I had in mind for a while. I've been working on a branch for a while that should at the very least provide plan stats to the Markdown template renderer, which combined with overriding the templates would allow for people to do something similar to what you mention. I'll try and make it a PR soon. |
We frequently plan multiple "projects" at the same time. Scanning trough the text looking for ~10-15 "No changes" is rather annoying and could be overlooked easily. Could this somehow stand out more?
E.g. by adding an emoji or making the text bold?
It would also be nice if Atlantis could be more verbose in regards to the number of failed, unchanged projects e.g.:
The text was updated successfully, but these errors were encountered: