Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Docker 23.0.0 required to deploy Atlantis with ACI #3291

Closed
patrick-merchant opened this issue Apr 4, 2023 · 5 comments · Fixed by #3293
Closed

Documentation: Docker 23.0.0 required to deploy Atlantis with ACI #3291

patrick-merchant opened this issue Apr 4, 2023 · 5 comments · Fixed by #3293
Labels
bug Something isn't working docs Documentation help wanted Good feature for contributors quick-win Is obviously something Atlantis should do and will take <4 hrs work

Comments

@patrick-merchant
Copy link
Contributor

patrick-merchant commented Apr 4, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

If using Docker pre-23.0.0 (e.g. Docker Desktop uses 20.10.23), Atlantis releases since v0.23.0 cannot be deployed using Azure Container Instances, returning the following error:

Error: The image 'runatlantis/atlantis' is not accessible. Please check the image and registry credential.

Apparently ACI requires images to have a manifest (as per the answer in https://learn.microsoft.com/en-us/answers/questions/1179992/(inaccessibleimage)-the-image-docker-io-presearch).

Looks related to this issue around OCI image types not having a manifest: moby/moby#43126.

Fix has been added in docker 23.0.0 docker/cli#3990.

Reproduction Steps

With docker < 23.0.0:

Run docker manifest inspect ghcr.io/runatlantis/atlantis:latest

Result: no such manifest: ghcr.io/runatlantis/atlantis:latest

Environment details

  • Atlantis version: v0.23.3
  • Deployment method: Azure Container Instances

Describe the solution you'd like

It could be helpful to have a note in the deployment docs at https://www.runatlantis.io/docs/deployment.html#microsoft-azure, specifying that - for ACI deployment - either docker 23.0.0 is required or the image must be pulled and pushed to a private registry like ACR.

@patrick-merchant patrick-merchant added the bug Something isn't working label Apr 4, 2023
@patrick-merchant patrick-merchant changed the title Documentation: Docker 23.0.2 required to deploy Atlantis with ACI Documentation: Docker 23.0.0 required to deploy Atlantis with ACI Apr 4, 2023
@GenPage GenPage added help wanted Good feature for contributors quick-win Is obviously something Atlantis should do and will take <4 hrs work docs Documentation labels Apr 4, 2023
@jamengual
Copy link
Contributor

@patrick-merchant feel free to propose a PR

@patrick-merchant
Copy link
Contributor Author

@jamengual PR here: #3293

@ausfestivus
Copy link

Just for some further info about this, we raised this issue with MS via Premier Support to try and get some traction with the product team in the hopes they might actually fix the issue in ACI.

WONT FIX was the answer.

Thanks for your reply. Per checking with our product engineer, I‘m afraid that there are no plans to have ACI support images with no manifests. It's a by design limitation.

The workaround is to setup an ACR with the Atlantis image and use the image from that instead.

@ausfestivus
Copy link

FYI, I pushed back on MS about this situation. This morning MS has advised me that the underlying issue in ACI which caused this has been fixed.

I tested it out and I was able to run Atlantis v0.23.5 directly without going through ACR.

Screenshot 2023-05-17 at 9 54 31 am

@jamengual did you want a new issue for the doco update or happy to reopen and run with this issue?

@jamengual
Copy link
Contributor

ohhh ok, let's do a doc update please and link this issue.

thanks @ausfestivus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Documentation help wanted Good feature for contributors quick-win Is obviously something Atlantis should do and will take <4 hrs work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants