Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATLANTIS_HIDE_PREV_PLAN_COMMENTS=true has no effect on gitlab #3835

Closed
gurpalw opened this issue Oct 9, 2023 · 1 comment
Closed

ATLANTIS_HIDE_PREV_PLAN_COMMENTS=true has no effect on gitlab #3835

gurpalw opened this issue Oct 9, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@gurpalw
Copy link
Contributor

gurpalw commented Oct 9, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

atlantis-0:/$ env | grep PREV
ATLANTIS_HIDE_PREV_PLAN_COMMENTS=true

ATLANTIS_HIDE_PREV_PLAN_COMMENTS has no effect when using gitlab despite the docs saying it should work. previous atllantis comments still show up and are not collapsed or hidden.

Reproduction Steps

use gitlab to run an atlantis plan. then run another and note the previous one isn't hidden.

determined GitLab is running version 16.5.0
atlantis v0.24.1 (commit: d8c1448) (build date: 2023-05-24T13:22:21.648Z)

Logs

Environment details

Additional Context

@gurpalw gurpalw added the bug Something isn't working label Oct 9, 2023
@X-Guardian
Copy link
Contributor

Support for HIDE_PREV_PLAN_COMMENTS was added for GitLab in release v.0.24.3. PR: #3476

@gurpalw gurpalw closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants