-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External backend for Locking. #894
Comments
I just installed Atlantis and hit an edge case with that. |
From my brief experiment with Cloud Run, there will be other challenges to address around eventing. Once Atlantis sends a response to GitHub's webhook, Cloud Run terminates atlantis container, which actually performs background processing. Therefore there is a need to launch Atlantis background processing via a separate Cloud Run endpoint/event before responding back to the GitHub. |
Any updates/remaining interest in this one? Would be such a nice-to-have.. |
Would definitely be very welcome if this feature could be implemented. |
@dmitri-lerko, since late last year, it is possible to have an always-on Cloud Run container. By the way, we currently run Atlantis on Google Cloud App Engine, but it is in my plans to migrate to Cloud Run in the future. As soon as I do, I'll post an update here. |
Would definitely be very welcome if this feature could be implemented. |
It's already implemented. See the updated docs, you can now use redis. This issue should be closed |
@idlebot , have you migrated yet? Would like to know your experience. |
@JonGilmore @nitrocode Can the main documentation be also be updated to reflect this? |
Yes of course. This is an open source project and we welcome contributions. For anyone who would like to contribute, please see the runatlantis.io directory of this repo. |
It would be a huge architectural improvement if we can turn the Atlantis server into a stateless container with external transactional storage for locks.
An abstract key-value store that implements the Backend interface seems to be a good start. We can start with a simple implementation such as the leveldb and the community can add more implementations.
Rationale
Benefits
Related: #264
The text was updated successfully, but these errors were encountered: