Update README.md #153
Merged
Update README.md #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enterprise github hostname in documentation.
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 41 41
Lines 1969 1969
=======================================
Hits 1263 1263
Misses 641 641
Partials 65 65Continue to review full report at Codecov.
|
lkysow
approved these changes
Jun 21, 2018
README.md
Outdated
| @@ -392,6 +398,7 @@ $ atlantis server --atlantis-url $URL --gitlab-user $USERNAME --gitlab-token $TO | |||
| - `$USERNAME` is the GitHub/GitLab username you generated the token for | |||
| - `$TOKEN` is the access token you created. If you don't want this to be passed in as an argument for security reasons you can specify it in a config file (see [Configuration](#configuration)) or as an environment variable: `ATLANTIS_GH_TOKEN` or `ATLANTIS_GITLAB_TOKEN` | |||
| - `$SECRET` is the random key you used for the webhook secret. If you left the secret blank then don't specify this flag. If you don't want this to be passed in as an argument for security reasons you can specify it in a config file (see [Configuration](#configuration)) or as an environment variable: `ATLANTIS_GH_WEBHOOK_SECRET` or `ATLANTIS_GITLAB_WEBHOOK_SECRET` | |||
| - `$GITHUBHOSTNAME` is the URL of your enterprise Github | |||
There was a problem hiding this comment.
can you give an example here? So people know if it should contain the scheme or not (it shouldn't). Like:
... is the URL of your enterprise GitHub, ex. github.mycompany.com (don't add https://).
example update for gh-hostname parameter
|
Thanks! |
jamengual
pushed a commit
that referenced
this pull request
Nov 23, 2022
meringu
pushed a commit
to meringu/atlantis
that referenced
this pull request
May 29, 2023
Test github_comment_renderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enterprise github hostname in documentation. I mean it is not too hard to find it in the codebase, but it is nicer here.