Ensure terraform_version is downloaded when using non built-in step. Fixes #675 #722
Conversation
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
==========================================
- Coverage 72.45% 72.37% -0.08%
==========================================
Files 61 61
Lines 4679 4695 +16
==========================================
+ Hits 3390 3398 +8
- Misses 1039 1044 +5
- Partials 250 253 +3
Continue to review full report at Codecov.
|
maximede
force-pushed
the
issue-675
branch
2 times, most recently
from
5829859 to
6190d38
Compare
|
Thanks @maximede, can you remove the binary that was committed here? We should add that to our .gitignore, simple easy to accidentally commit that. |
Good catch, sorry I missed the file. |
| c.versionsLock.Lock() | ||
| _, err = ensureVersion(log, c.downloader, c.versions, v, c.binDir) | ||
| c.versionsLock.Unlock() | ||
| if err != nil { |
|
|
||
| err := r.TerraformExecutor.EnsureVersion(ctx.Log, tfVersion) | ||
| if err != nil { | ||
| err = fmt.Errorf("%s: Downloading terraform Version %s", err, tfVersion.String()) |
There was a problem hiding this comment.
Use errors.Wrapf, use all lowercase:
err = errors.Wrapf(err, "downloading terraform version %s", tfVersion.String()
| err := r.TerraformExecutor.EnsureVersion(ctx.Log, tfVersion) | ||
| if err != nil { | ||
| err = fmt.Errorf("%s: Downloading terraform Version %s", err, tfVersion.String()) | ||
| ctx.Log.Debug("error: %s", err) |
There was a problem hiding this comment.
I see that this is a Debug log below as well but I think this makes more sense as an Err log
No description provided.