Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Secret Password Key #434

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Redis Secret Password Key #434

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b538425
Redis Secret Password Key
JohnLahr Oct 31, 2024
296c0b8
Update charts/atlantis/values.yaml
JohnLahr Nov 2, 2024
a038033
added unit tests for Redis variables
JohnLahr Nov 3, 2024
fa9d1d1
fixed incorrect default value in README
JohnLahr Nov 3, 2024
5080dc3
fixed incorrect test value
JohnLahr Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/atlantis/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: v1
appVersion: v0.30.0
description: A Helm chart for Atlantis https://www.runatlantis.io
name: atlantis
version: 5.8.0
version: 5.9.0
keywords:
- terraform
home: https://www.runatlantis.io
Expand Down
1 change: 1 addition & 0 deletions charts/atlantis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ extraManifests:
| readinessProbe.timeoutSeconds | int | `5` | |
| redis | object | `{}` | Configure Redis Locking DB. lockingDbType value must be redis for the config to take effect. Check values.yaml for examples. |
| redisSecretName | string | `""` | When managing secrets outside the chart for the Redis secret, use this variable to reference the secret name. |
| redisSecretPasswordKey | string | `""` | Key within the existing Redis secret that contains the password value. |
| replicaCount | int | `1` | Replica count for Atlantis pods. |
| repoConfig | string | `""` | Use Server Side Repo Config, ref: https://www.runatlantis.io/docs/server-side-repo-config.html. Check values.yaml for examples. |
| resources | object | `{}` | Resources for Atlantis. Check values.yaml for examples. |
Expand Down
2 changes: 1 addition & 1 deletion charts/atlantis/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ spec:
valueFrom:
secretKeyRef:
name: {{ template "atlantis.redisSecretName" . }}
key: password
key: {{ .Values.redisSecretPasswordKey | quote }}
{{- end }}
{{- if .Values.redis.port }}
- name: ATLANTIS_REDIS_PORT
Expand Down
6 changes: 5 additions & 1 deletion charts/atlantis/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,7 +1283,11 @@
},
"redisSecretName": {
"type": "string",
"description": "Name of a pre-existing Kubernetes `Secret` containing a `password` key. Use this instead of `redis.password`."
"description": "Name of a pre-existing Kubernetes `Secret` containing the password for Redis. Use this instead of `redis.password`."
},
"redisSecretPasswordKey": {
"type": "string",
"description": "Key within the existing Redis `Secret` that contains the password value."
},
"lifecycle": {
"type": "object",
Expand Down
3 changes: 3 additions & 0 deletions charts/atlantis/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,6 +731,9 @@ redis: {}
# -- When managing secrets outside the chart for the Redis secret, use this variable to reference the secret name.
redisSecretName: ""

# -- Key within the existing Redis secret that contains the password value.
redisSecretPasswordKey: "password"
JohnLahr marked this conversation as resolved.
Show resolved Hide resolved

# -- Set lifecycle hooks.
# https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/.
lifecycle: {}
Loading