Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function and Record properties should fail no-incompatible-property-type #350

Open
steverep opened this issue Jan 20, 2024 · 1 comment
Open

Comments

@steverep
Copy link

Properties which have a function type should fail the no-incompatible-property-type rule unless a custom converter is provided. For example, this should fail as String certainly will not result in a valid conversion:

@property() public funcProp?: () => void;

For function properties, only including a custom converter or {attribute: false} should pass the rule.

@steverep
Copy link
Author

I also noticed that Record<...> types also pass with the default String converter, and they certainly should not.

@steverep steverep changed the title Function properties should fail no-incompatible-property-type Function and Record properties should fail no-incompatible-property-type Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant