From cb339061e75e20e147035d4307309dcbd5c0ede1 Mon Sep 17 00:00:00 2001 From: rictic Date: Fri, 14 Jan 2022 10:44:40 -0600 Subject: [PATCH 1/2] Update github actions to include latest node LTS. --- .github/workflows/workflow.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml index db11d945..9ec6dac3 100644 --- a/.github/workflows/workflow.yml +++ b/.github/workflows/workflow.yml @@ -15,7 +15,7 @@ jobs: strategy: matrix: os: [windows-latest, ubuntu-latest] - node: [12, 14] + node: [12, 14, 16] steps: - name: Checkout code @@ -36,7 +36,6 @@ jobs: run: npm run lint - name: Prettier - if: matrix.os == 'ubuntu-latest' run: npm run prettier:check - name: Test @@ -48,7 +47,7 @@ jobs: - name: Upload artifacts uses: actions/upload-artifact@master - if: matrix.os == 'ubuntu-latest' + if: matrix.os == 'ubuntu-latest' && matrix.node == 16 with: name: vscode-lit-plugin - path: vscode-lit-plugin + path: vscode-lit-plugin # is this right? the actual path is packages/vscode-lit-plugin From 11d035b23cc8e5fcf7a58c26c44af836efc96ac0 Mon Sep 17 00:00:00 2001 From: rictic Date: Fri, 14 Jan 2022 11:17:14 -0600 Subject: [PATCH 2/2] Only run prettier on ubuntu --- .github/workflows/workflow.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml index 9ec6dac3..095ff56c 100644 --- a/.github/workflows/workflow.yml +++ b/.github/workflows/workflow.yml @@ -36,6 +36,7 @@ jobs: run: npm run lint - name: Prettier + if: matrix.os == 'ubuntu-latest' # this fails on windows. newlines? run: npm run prettier:check - name: Test