[Discussion] Make plugin project isolation compatible #384
+155
−76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use this PR has a starting point to discuss making this plugin Project Isolation compatible and solving #302.
I believe what I have right now to be the minimal amount of changes needed to support project isolation. Before I commit to further work on this, I wanted to get some feedback on the approach here.
Main changes:
DoctorPlugin
is now broken up into 3 plugins: a settings pluginDoctorSettingsPlugin
, a root project pluginDoctorPlugin
, and a module pluginDoctorChildModulePlugin
com.osacky.doctor
now points to the settings plugin class and must be applied in settings.gradleallowBuildingAllAndroidAppsSimultaneously
settings. Though I'm not sure how useful this actually isFrom my testing on our large 900+ module project it seems to work as before and no longer violates project isolation. I have not tested if there are any differences in performance.