Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better "missing region" penalties #10

Open
ryan-williams opened this issue Oct 12, 2023 · 0 comments
Open

Better "missing region" penalties #10

ryan-williams opened this issue Oct 12, 2023 · 0 comments

Comments

@ryan-williams
Copy link
Member

The "missing region penalty" (step.rs) should be proportional to the distance each shape is from the required region existing. Among other improvements, this would allow shapes to rotate to get closer to one another.

Currently, I just move their centers closer together, which often just causes them to thrash against added error in other regions, and not converge.

Training examples starting from the "Disjoint" layout is one way to see this in action:

disjoint-variant-callers.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant