Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scroll-handler): only update scroll handler length when elements array changes #128

Merged
merged 1 commit into from
Sep 13, 2016
Merged

fix(scroll-handler): only update scroll handler length when elements array changes #128

merged 1 commit into from
Sep 13, 2016

Conversation

adamjmcgrath
Copy link
Contributor

I noticed that vertical-collection throws an error when you load 2 instances on the same page:

scroll-handler.js:96 Uncaught TypeError: Cannot read property 'scrollTop' of undefined

This was because this.length didn't match the number of elements in this.elements when addElementHandler is called twice with the same element (The Container)

@runspired runspired merged commit a912964 into html-next:develop Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjmcgrath @runspired