From 56ebd46bc3f5b6b4220a16e614c240414711c806 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Wed, 4 Nov 2020 17:33:30 +1100 Subject: [PATCH] lib-test_bitmapc-add-for_each_set_clump-test-cases-checkpatch-fixes ERROR: that open brace { should be on the previous line #151: FILE: lib/test_bitmap.c:648: +static struct clump_test_data_params clump_test_data[] __initdata = + { {{0}, 2, 0, 64, 8, clump_exp1}, ERROR: that open brace { should be on the previous line #161: FILE: lib/test_bitmap.c:658: + for(i = 0; i < clump_test_data[index].count; i++) + { ERROR: space required before the open parenthesis '(' #161: FILE: lib/test_bitmap.c:658: + for(i = 0; i < clump_test_data[index].count; i++) ERROR: that open brace { should be on the previous line #169: FILE: lib/test_bitmap.c:666: +static void __init execute_for_each_set_clump_test(unsigned int index) +{ WARNING: suspect code indent for conditional statements (8, 8) #173: FILE: lib/test_bitmap.c:670: + for_each_set_clump(start, clump, clump_test_data[index].data, [...] + expect_eq_clump(start, clump_test_data[index].limit, clump_test_data[index].exp, ERROR: that open brace { should be on the previous line #180: FILE: lib/test_bitmap.c:677: +static void __init test_for_each_set_clump(void) +{ total: 5 errors, 1 warnings, 174 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/lib-test_bitmapc-add-for_each_set_clump-test-cases.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Syed Nayyar Waris Signed-off-by: Andrew Morton Signed-off-by: Stephen Rothwell --- lib/test_bitmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c index 91b3455bddab39..1c5791ff02cb07 100644 --- a/lib/test_bitmap.c +++ b/lib/test_bitmap.c @@ -655,8 +655,7 @@ static void __init prepare_test_data(unsigned int index) int i; unsigned long width = 0; - for(i = 0; i < clump_test_data[index].count; i++) - { + for (i = 0; i < clump_test_data[index].count; i++) { bitmap_set_value(clump_test_data[index].data, clump_bitmap_data[(clump_test_data[index].offset)++], width, 32); width += 32;