Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize KeychainSettings #121

Open
russhwolf opened this issue Jul 17, 2022 · 10 comments
Open

Stabilize KeychainSettings #121

russhwolf opened this issue Jul 17, 2022 · 10 comments

Comments

@russhwolf
Copy link
Owner

Currently, KeychainSettings is considered experimental because I want to be cautious about security-related APIs and I've had very little feedback. Please report this ticket if it is or isn't working for you so I can get a sense of when it's ready to be marked stable.

@russhwolf
Copy link
Owner Author

This is NOT blocked by #71. There are currently no known issues, just a lack of testing and feedback.

@vanniktech
Copy link
Contributor

Switched out NSUserDefaultSettings with KeychainSettings. I've tried using it once, got the feedback that it wasn't working. Like the values weren't persisted. Didn't look into it again though. Could be something on my side as well. Lazy: Is there anything that needs to be enabled on iOS side in order to use the Keychain?

@russhwolf
Copy link
Owner Author

There shouldn't be any extra config necessary. The sample app has an option to use it so maybe compare against that.

@archiegq21
Copy link

Just wondering if KeychainSetting would also implement ObservableSettings in the future as well?

@russhwolf
Copy link
Owner Author

See #71. Unfortunately, I'm not aware of a way to observe keychain updates that works outside of macOS.

@lukepistrol
Copy link

Just to let you know we use KeychainSettings in one of our projects and it works nicely!

@vanniktech
Copy link
Contributor

Can't this be closed since 1.0.0 is released?

@russhwolf
Copy link
Owner Author

It's still marked experimental in 1.0.0

@sebj
Copy link

sebj commented Feb 10, 2023

Using KeychainSettings in a project at the moment, providing a couple extra default properties (kSecAttrAccessible & kSecAttrAccessGroup) – seems to be working well, haven't found any issues (will update if there are any)

Edit: opened #144

@ryanw-mobile
Copy link

Can't believe it's now 2024.
I don't know much about iOS, but it works without issues when I only have to store key-string pairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants