Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add basic support for Native Debug #16719

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Feb 29, 2024

Native Debug doesn't work very well and passing command-line arguments is nasty (#9815), but I guess it's a start.

Closes #9815

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 29, 2024
@lnicola lnicola force-pushed the native-debug branch 2 times, most recently from 8c6c0fe to 26352e1 Compare February 29, 2024 14:10
@lnicola
Copy link
Member Author

lnicola commented Mar 1, 2024

r? @Young-Flash

@lnicola
Copy link
Member Author

lnicola commented Mar 4, 2024

@bors r+ yolo

@bors
Copy link
Collaborator

bors commented Mar 4, 2024

📌 Commit a01e4f8 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 4, 2024

⌛ Testing commit a01e4f8 with merge d444acd...

@bors
Copy link
Collaborator

bors commented Mar 4, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing d444acd to master...

@bors bors merged commit d444acd into rust-lang:master Mar 4, 2024
11 checks passed
@lnicola lnicola deleted the native-debug branch March 4, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support more debug engine in VSCode plugin
3 participants