Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix projects depending on rustc_private hanging #16911

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 21, 2024

If loading the root fails, we'll hang up in this loop as we never inserted the entry that asserts we already visited a package. This fixes that
Fixes #16902

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 21, 2024
@Veykril
Copy link
Member Author

Veykril commented Mar 21, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 21, 2024

📌 Commit 2ad14b8 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 21, 2024

⌛ Testing commit 2ad14b8 with merge a3d9625...

@bors
Copy link
Contributor

bors commented Mar 21, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing a3d9625 to master...

@bors bors merged commit a3d9625 into rust-lang:master Mar 21, 2024
11 checks passed
@Veykril Veykril deleted the rustc-crates branch March 21, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stuck at "Building CrateGraph" in rust-lang/rust repo
3 participants