Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability to configure the user config path #17930

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Aug 19, 2024

Being able to do this makes little sense as this is effectively a cyclic dependency (and we do not want to fixpoint this really).

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2024
@Veykril
Copy link
Member Author

Veykril commented Aug 19, 2024

@bors delegate=@alibektas

@bors
Copy link
Contributor

bors commented Aug 19, 2024

✌️ @alibektas, you can now approve this pull request!

If @Veykril told you to "r=me" after making some further change, please make that change, then do @bors r=@Veykril

@alibektas
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 20, 2024

📌 Commit 90e08d3 has been approved by alibektas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 20, 2024

⌛ Testing commit 90e08d3 with merge 0e8df6f...

@bors
Copy link
Contributor

bors commented Aug 20, 2024

☀️ Test successful - checks-actions
Approved by: alibektas
Pushing 0e8df6f to master...

@bors bors merged commit 0e8df6f into rust-lang:master Aug 20, 2024
11 checks passed
@Veykril Veykril deleted the config-user-config branch August 20, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants