fix: Don't add reference when it isn't needed for the "Extract variable" assist #17991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st method and field accesses.
…ssist I.e. don't generate `let var_name = &foo()`. Anything that creates a new value don't need a reference. That excludes mostly field accesses and indexing. I had a thought that we can also not generate a reference for fields and indexing as long as the type is `Copy`, but sometimes people impl `Copy` even when they don't want to copy the values (e.g. a large type), so I didn't do that.
rustbot
added
the
S-waiting-on-review
And BTW, remove the parentheses of the extracted expression if there are.
Veykril
approved these changes
Aug 29, 2024
| .as_ref() | ||
| .map_or(false, |it| matches!(it, ast::Expr::FieldExpr(_) | ast::Expr::MethodCallExpr(_))); | ||
| // Any expression that autoderefs may need adjustment. | ||
| let mut needs_adjust = parent.as_ref().map_or(false, |it| match it { |
There was a problem hiding this comment.
I wonder, couldn't we check if the type of let ty = ctx.sema.type_of_expr(&to_extract).map(TypeInfo::adjusted); and let ty = ctx.sema.type_of_expr(&to_extract).map(TypeInfo::original); differs to tell this? I guess we are only interested in autoderef adjustments so probably not
|
Thanks! This has bothered me for a long time (I wonder if I made an issue regarding that) |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. don't generate
let var_name = &foo(). Because it always irritates me when I need to fix that.Anything that creates a new value don't need a reference. That excludes mostly field accesses and indexing.
I had a thought that we can also not generate a reference for fields and indexing as long as the type is
Copy, but sometimes people implCopyeven when they don't want to copy the values (e.g. a large type), so I didn't do that.