-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port sequence combinators to the new design #899
Comments
My two cents; I feel like keeping the number of macros/combinators to a minimum would be a good thing. One of the things that made it harder for me to get used to the library initially was the vast amount of macros that all looked very similar at a first glance. Though this might already be better if there's better documentation in 5.0. Edit: Maybe separating things out to different (sub)crates might be a good idea? |
I want to remove a few combinators, and I'll separate functions in more modules. A big issue with macros was that they are all at the top level, so we often have to look them up in alphabetical order. functions can have a more coherent organization. |
the methods combinators and whitespace combinators will move out in other crates, I don't know yet about others |
all the sequence combinators are now ported to functions. the |
for most cases this is not too useful since we can just write a parser function in imperative style, but applying a tuple of parsers in order could still be interesting. The code is in
src/sequence/macros.rs
. To rewrite:tuple
do_parse
: is it necessary?The text was updated successfully, but these errors were encountered: