Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo build fails #46

Open
kcalvinalvin opened this issue Feb 5, 2021 · 4 comments · May be fixed by #47
Open

Cargo build fails #46

kcalvinalvin opened this issue Feb 5, 2021 · 4 comments · May be fixed by #47

Comments

@kcalvinalvin
Copy link

Just git cloning the master branch and cargo build is failing.

log:

[I] > cargo build
   Compiling hammersbald v2.4.0
error[E0603]: module `export` is private
   --> /home/calvin/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/hammersbald-2.4.0/src/bitcoin_adaptor.rs:34:12
    |
34  | use serde::export::PhantomData;
    |            ^^^^^^ private module
    |
note: the module `export` is defined here
   --> /home/calvin/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/serde-1.0.123/src/lib.rs:275:5
    |
275 | use self::__private as export;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0603`.
error: could not compile `hammersbald`

To learn more, run the command again with --verbose.
@sgeisler
Copy link
Contributor

sgeisler commented Feb 5, 2021

Murmel isn't that well maintained. The error you see is clearly a mishap in hammersbald (probably by IntelliJ Rust, which can auto-import stuff and accidentally took PhantomData from serde::export instead of std::markers). I guess a recent serde update fixed the std re-export and broke the build that way.

Version 3 of hammersbald already has a fix for it (relevant commit). You could try to migrate murmel to the new hammersbald version or just fix the import and use your patched version locally.

@stevenroose stevenroose linked a pull request Feb 5, 2021 that will close this issue
Open
@stevenroose
Copy link
Collaborator

#47 fixes this issue, @kcalvinalvin could you verify that it works for you?

@kcalvinalvin
Copy link
Author

#47 fixes this issue, @kcalvinalvin could you verify that it works for you?

Yes it works for me on commit hash 8b93a33884956970c8c87bde2d00c934d8bca440

@chrisguida
Copy link

chrisguida commented Feb 9, 2021 •
edited
Loading

Can confirm that master was broken as described above, and #47 fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update bitcoin and hammersbald dependencies stevenroose/murmel
4 participants
@stevenroose @sgeisler @chrisguida @kcalvinalvin