Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve code quality #286

Merged
merged 4 commits into from
Jan 29, 2022
Merged

improve code quality #286

merged 4 commits into from
Jan 29, 2022

Conversation

danieleades
Copy link
Contributor

another little code quality update

matthiasbeyer
matthiasbeyer approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not in favour of such big multi-hundred line diffs that consist only of one commit... any chance that you split the commit up into several smaller ones?

The diff itself looks good to me.

@danieleades danieleades force-pushed the refactor/code-quality branch from 4ed557f to aaa1601 Compare January 29, 2022 13:01
@matthiasbeyer matthiasbeyer merged commit 68e0025 into rust-cli:master Jan 29, 2022
@danieleades danieleades deleted the refactor/code-quality branch January 29, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieleades @matthiasbeyer