Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update postgres and tokio-postgres #138

Merged
merged 5 commits into from
Oct 25, 2020
Merged

update postgres and tokio-postgres #138

merged 5 commits into from
Oct 25, 2020

Conversation

AtsukiTak
Copy link
Contributor

Thanks for providing this crate!

postgres 0.18.1 and tokio-postgres 0.6.0 are released recently.
It would be straightforward. Please update 😄

@jxs jxs closed this Oct 23, 2020
@jxs jxs reopened this Oct 23, 2020
@jxs
Copy link
Member

jxs commented Oct 23, 2020

Hi, and thanks! Sorry I had to close and re-open again to trigger the CI pipeline which stalled.
Hum Tests seem to be failing

@AtsukiTak
Copy link
Contributor Author

Oh dear, that's not straightforward at all 😭

The problem is that tokio-postgres depends on tokio v0.3 but mysql_async depends on v0.2.
I've updated tokio crate to 0.3 and imported tokio-compat-02 crate to pass mysq_async tests.

But sadly, tokio-compat-02 seems not to be compilable by this issue. For now, tokio-compat-02 crate points GitHub directly but we need to fix it when a new version is released.

@Darksonn
Copy link

You can also add the feature yourself since features are merged across all uses of the crate.

@AtsukiTak
Copy link
Contributor Author

@Darksonn Thanks for comment! And also thanks for releasing a new version of tokio-compat-02 !

You can also add the feature yourself since features are merged across all uses of the crate.

I didn't know that, thanks 😄 But now, I'm confusing since we enabled the full feature of tokio crate in the refinery_core crate which is used by refinery crate. Maybe I missed something. Would you like to tell me the reason why we got that error?

@Darksonn
Copy link

The tokio-compat-02 crate uses the stream feature of Tokio 0.3, not of 0.2.

mysql_async = { version = "0.25", optional = true }

tokio = { version = "0.2", features = ["full"], optional = true }
tokio = { version = "0.3", features = ["full"], optional = true }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tokio-compat-02 crate uses the stream feature of Tokio 0.3, not of 0.2.

Oh sorry, I pasted wrong link...
This code enables full feature of Tokio 0.3 but error occurs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it's marked optional? If it isn't enabled, it wouldn't have an effect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's enabled by refinery crate (for which we did test)

@jxs jxs merged commit f69e5f5 into rust-db:master Oct 25, 2020
@jxs
Copy link
Member

jxs commented Oct 25, 2020

LGTM thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants