-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update postgres and tokio-postgres #138
Conversation
Hi, and thanks! Sorry I had to close and re-open again to trigger the CI pipeline which stalled. |
Oh dear, that's not straightforward at all 😭 The problem is that But sadly, |
You can also add the feature yourself since features are merged across all uses of the crate. |
@Darksonn Thanks for comment! And also thanks for releasing a new version of
I didn't know that, thanks 😄 But now, I'm confusing since we enabled the |
The tokio-compat-02 crate uses the stream feature of Tokio 0.3, not of 0.2. |
mysql_async = { version = "0.25", optional = true } | ||
|
||
tokio = { version = "0.2", features = ["full"], optional = true } | ||
tokio = { version = "0.3", features = ["full"], optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tokio-compat-02 crate uses the stream feature of Tokio 0.3, not of 0.2.
Oh sorry, I pasted wrong link...
This code enables full
feature of Tokio 0.3 but error occurs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it's marked optional? If it isn't enabled, it wouldn't have an effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's enabled by refinery crate (for which we did test)
LGTM thanks! |
Thanks for providing this crate!
postgres
0.18.1 andtokio-postgres
0.6.0 are released recently.It would be straightforward. Please update 😄