Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front End eslint #147

Closed
AlexPikalov opened this issue Jul 21, 2017 · 0 comments
Closed

Front End eslint #147

AlexPikalov opened this issue Jul 21, 2017 · 0 comments

Comments

@AlexPikalov
Copy link
Contributor

I believe it makes sense to have eslint step in CI from the FE end. It would check existing codebase for plenty of things such as unused vars, using undeclared vars, proper using var vs let vs const, code format, missed semicolons and a lot of other.

I've briefly checked current code and the linter has been able to find a lot of stuff which could (and probably should) be improved. So it might make sense to fix it before including this step into CI.

@AlexPikalov AlexPikalov changed the title Front end eslint Front End eslint Jul 21, 2017
@nrc nrc closed this as completed in #151 Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant