Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if a field have doc on read function, then it should be put it in rust doc #733

Closed
eZioPan opened this issue Jun 9, 2023 · 2 comments · Fixed by #734
Closed

if a field have doc on read function, then it should be put it in rust doc #733

eZioPan opened this issue Jun 9, 2023 · 2 comments · Fixed by #734

Comments

@eZioPan
Copy link
Contributor

eZioPan commented Jun 9, 2023

https://github.com/rust-embedded/svd2rust/blob/ef56dd1daeaf0048184567d306ca3d5c9d7c0208/src/generate/register.rs#LL808C89-L808C89

Currently, only doc in write function or the write side of read-write functions has been put into rust #[doc = ...]
@burrbull
Copy link
Member

burrbull commented Jun 9, 2023

should be easy to fix.
Please, create pull request.

@eZioPan eZioPan mentioned this issue Jun 9, 2023
Merged
@eZioPan
Copy link
Contributor Author

eZioPan commented Jun 9, 2023

@burrbull would you please spare some time to check whether my modification is good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

let readable field fetch doc from svd description eZioPan/svd2rust
2 participants
@burrbull @eZioPan