-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Merge/MergeBy/MergeJoinBy
implementations
#711
Closed
Philippe-Cholet
wants to merge
9
commits into
rust-itertools:master
from
Philippe-Cholet:issue-701-part2
Closed
Merge Merge/MergeBy/MergeJoinBy
implementations
#711
Philippe-Cholet
wants to merge
9
commits into
rust-itertools:master
from
Philippe-Cholet:issue-701-part2
Commits on Jun 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7aee579 - Browse repository at this point
Copy the full SHA 7aee579View commit details
Commits on Jun 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0781f1d - Browse repository at this point
Copy the full SHA 0781f1dView commit details
Commits on Jun 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 587261f - Browse repository at this point
Copy the full SHA 587261fView commit details -
Merge
MergePredicate
andOrderingOrBool
traitsTo get rid of `const SAME: bool`, I wrap the function `F` in `MergeFuncLR` and `MergeFuncT`. Those `MergeFuncLR/T` have a parameter `T` (phantom field) to not have conflicting implementations of `MergePredicate<L, R>`. In `merge_join_by` definition, in order for the compiler to keep guessing left/right types, I kept `F: FnMut(&Self::Item, &J::Item) -> T`. But to not add `F: MergePredicate<Self::Item, J::Item>` that felt duplicate, I removed `T: OrderingOrBool...`, the user might lose `OrderingOrBool` information.
Configuration menu - View commit details
-
Copy full SHA for 6b8750c - Browse repository at this point
Copy the full SHA 6b8750cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f04424 - Browse repository at this point
Copy the full SHA 6f04424View commit details -
MergeFuncT
does not need a phantom fieldAnd I simplify `MergeFuncLR` and `MergeFuncT` to "tuple structs".
Configuration menu - View commit details
-
Copy full SHA for 81d371f - Browse repository at this point
Copy the full SHA 81d371fView commit details -
Fix
impl FusedIterator for MergeJoinBy
constraintsBasically because `PutBack<Fuse<I>>` is fused no matter if `I` is or not. Same for `J`.
Configuration menu - View commit details
-
Copy full SHA for 042ca7e - Browse repository at this point
Copy the full SHA 042ca7eView commit details
Commits on Jul 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c622606 - Browse repository at this point
Copy the full SHA c622606View commit details
Commits on Aug 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0a3f122 - Browse repository at this point
Copy the full SHA 0a3f122View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.