tests: cfg-ignore compat tests if there is no compat feature #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Cameron <nrc@ncameron.org>
This was referenced Mar 12, 2021
exrook
pushed a commit
to exrook/futures-rs
that referenced
this pull request
Apr 5, 2021
…ng#2353) Signed-off-by: Nick Cameron <nrc@ncameron.org>
exrook
pushed a commit
to exrook/futures-rs
that referenced
this pull request
Apr 10, 2021
…ng#2353) Signed-off-by: Nick Cameron <nrc@ncameron.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realise that
cargo testis meant to be run using--all-features, however, this is not obvious the first time one runs tests because the error about the missingcompatmodule happens first, and the helpful message about--all-featuresnever gets output. With this change, we get far enough into compilation that you get to see the helpful error message, not the unhelpful ones. I believe this is an improvement to a contributors first experience (it would have saved me some time, for sure) and that outweighs the small noise of having the additionalcfglines.