↪ cargo +nightly clippy lib: rand Updating registry `https://github.com/rust-lang/crates.io-index` Downloading rand_core v0.1.0-pre.0 Downloading libc v0.2.40 Compiling rand_core v0.1.0-pre.0 Compiling libc v0.2.40 Compiling rand v0.5.0-pre.0 (file:///Users/abreis/Downloads/rand) warning: you should put `ChaCha` between ticks in the documentation --> src/prng/chacha.rs:11:9 | 11 | //! The ChaCha random number generator. | ^^^^^^ | = note: #[warn(doc_markdown)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `ChaCha` between ticks in the documentation --> src/prng/chacha.rs:20:70 | 20 | /// A cryptographically secure random number generator that uses the ChaCha | ^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `ChaCha` between ticks in the documentation --> src/prng/chacha.rs:23:5 | 23 | /// ChaCha is a stream cipher designed by Daniel J. Bernstein [1], that we use | ^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `eSTREAM` between ticks in the documentation --> src/prng/chacha.rs:26:5 | 26 | /// eSTREAM [2]. | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `ChaCha` between ticks in the documentation --> src/prng/chacha.rs:28:5 | 28 | /// ChaCha uses add-rotate-xor (ARX) operations as its basis. These are safe | ^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `ChaCha` between ticks in the documentation --> src/prng/chacha.rs:34:14 | 34 | /// With the ChaCha algorithm it is possible to choose the number of rounds the | ^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `ChaCha20` between ticks in the documentation --> src/prng/chacha.rs:35:69 | 35 | /// core algorithm should run. By default `ChaChaRng` is created as ChaCha20, | ^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `ChaCha` between ticks in the documentation --> src/prng/chacha.rs:40:34 | 40 | /// We deviate slightly from the ChaCha specification regarding the nonce, which | ^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `ChaCha` between ticks in the documentation --> src/prng/chacha.rs:43:19 | 43 | /// works against ChaCha with a chosen-nonce. See the XSalsa20 [3] security | ^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `XSalsa20` between ticks in the documentation --> src/prng/chacha.rs:43:55 | 43 | /// works against ChaCha with a chosen-nonce. See the XSalsa20 [3] security | ^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `ChaCha` between ticks in the documentation --> src/prng/chacha.rs:55:29 | 55 | /// [1]: D. J. Bernstein, [*ChaCha, a variant of Salsa20*]( | ^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `eSTREAM` between ticks in the documentation --> src/prng/chacha.rs:58:11 | 58 | /// [2]: [eSTREAM: the ECRYPT Stream Cipher Project]( | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: long literal lacking separators --> src/prng/chacha.rs:282:21 | 282 | state: [0x61707865, 0x3320646E, 0x79622D32, 0x6B206574, // constants | ^^^^^^^^^^ | = note: #[warn(unreadable_literal)] on by default = help: consider: 0x6170_7865 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/chacha.rs:282:33 | 282 | state: [0x61707865, 0x3320646E, 0x79622D32, 0x6B206574, // constants | ^^^^^^^^^^ | = help: consider: 0x3320_646E = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/chacha.rs:282:45 | 282 | state: [0x61707865, 0x3320646E, 0x79622D32, 0x6B206574, // constants | ^^^^^^^^^^ | = help: consider: 0x7962_2D32 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/chacha.rs:282:57 | 282 | state: [0x61707865, 0x3320646E, 0x79622D32, 0x6B206574, // constants | ^^^^^^^^^^ | = help: consider: 0x6B20_6574 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: you should put `eSTREAM` between ticks in the documentation --> src/prng/hc128.rs:24:18 | 24 | /// adoption" by eSTREAM [2]. | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `eSTREAM` between ticks in the documentation --> src/prng/hc128.rs:35:5 | 35 | /// eSTREAM contest, but on a later version by the author with a few small | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `eSTREAM` between ticks in the documentation --> src/prng/hc128.rs:50:15 | 50 | /// *The eSTREAM Finalists*, LNCS 4986, pp. 39--47, Springer-Verlag. | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `eSTREAM` between ticks in the documentation --> src/prng/hc128.rs:52:11 | 52 | /// [2]: [eSTREAM: the ECRYPT Stream Cipher Project]( | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: 5th binding whose name is just one char --> src/prng/hc128.rs:187:21 | 187 | let c = (p.get_unchecked(i12) >> 16) as u8; | ^ | = note: #[warn(many_single_char_names)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 5th binding whose name is just one char --> src/prng/hc128.rs:212:21 | 212 | let c = (q.get_unchecked(i12) >> 16) as u8; | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 5th binding whose name is just one char --> src/prng/isaac.rs:188:17 | 188 | let y = *a + *b + ind(&ctx.mem, x, 2); | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 5th binding whose name is just one char --> src/prng/isaac.rs:294:13 | 294 | let mut e = w(0xd92a4a78); | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 6th binding whose name is just one char --> src/prng/isaac.rs:295:13 | 295 | let mut f = w(0xa51a3c49); | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 7th binding whose name is just one char --> src/prng/isaac.rs:296:13 | 296 | let mut g = w(0xc4efea1b); | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 8th binding whose name is just one char --> src/prng/isaac.rs:297:13 | 297 | let mut h = w(0x30609119); | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: you should put bare URLs between `<`/`>` or make a proper Markdown link --> src/prng/isaac.rs:263:5 | 263 | /// https://rt.cpan.org/Public/Bug/Display.html?id=64324 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: long literal lacking separators --> src/prng/isaac.rs:290:19 | 290 | let mut a = w(0x1367df5a); | ^^^^^^^^^^ | = help: consider: 0x1367_df5a = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac.rs:291:19 | 291 | let mut b = w(0x95d90059); | ^^^^^^^^^^ | = help: consider: 0x95d9_0059 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac.rs:292:19 | 292 | let mut c = w(0xc3163e4b); | ^^^^^^^^^^ | = help: consider: 0xc316_3e4b = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac.rs:293:19 | 293 | let mut d = w(0x0f421ad8); | ^^^^^^^^^^ | = help: consider: 0x0f42_1ad8 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac.rs:294:19 | 294 | let mut e = w(0xd92a4a78); | ^^^^^^^^^^ | = help: consider: 0xd92a_4a78 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac.rs:295:19 | 295 | let mut f = w(0xa51a3c49); | ^^^^^^^^^^ | = help: consider: 0xa51a_3c49 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac.rs:296:19 | 296 | let mut g = w(0xc4efea1b); | ^^^^^^^^^^ | = help: consider: 0xc4ef_ea1b = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac.rs:297:19 | 297 | let mut h = w(0x30609119); | ^^^^^^^^^^ | = help: consider: 0x3060_9119 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: 5th binding whose name is just one char --> src/prng/isaac.rs:331:8 | 331 | e: &mut w32, f: &mut w32, g: &mut w32, h: &mut w32) { | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 6th binding whose name is just one char --> src/prng/isaac.rs:331:21 | 331 | e: &mut w32, f: &mut w32, g: &mut w32, h: &mut w32) { | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 7th binding whose name is just one char --> src/prng/isaac.rs:331:34 | 331 | e: &mut w32, f: &mut w32, g: &mut w32, h: &mut w32) { | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 8th binding whose name is just one char --> src/prng/isaac.rs:331:47 | 331 | e: &mut w32, f: &mut w32, g: &mut w32, h: &mut w32) { | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: you should put `rand::prng::IsaacRng` between ticks in the documentation --> src/prng/isaac64.rs:67:49 | 67 | /// See for more information the description in rand::prng::IsaacRng. | ^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: 5th binding whose name is just one char --> src/prng/isaac64.rs:173:17 | 173 | let y = *a + *b + ind(&ctx.mem, x, 3); | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 5th binding whose name is just one char --> src/prng/isaac64.rs:273:13 | 273 | let mut e = w(0x82f053db8355e0ce); | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 6th binding whose name is just one char --> src/prng/isaac64.rs:274:13 | 274 | let mut f = w(0x48fe4a0fa5a09315); | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 7th binding whose name is just one char --> src/prng/isaac64.rs:275:13 | 275 | let mut g = w(0xae985bf2cbfc89ed); | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 8th binding whose name is just one char --> src/prng/isaac64.rs:276:13 | 276 | let mut h = w(0x98f5704f6c44c0ab); | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: long literal lacking separators --> src/prng/isaac64.rs:269:19 | 269 | let mut a = w(0x647c4677a2884b7c); | ^^^^^^^^^^^^^^^^^^ | = help: consider: 0x647c_4677_a288_4b7c = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac64.rs:270:19 | 270 | let mut b = w(0xb9f8b322c73ac862); | ^^^^^^^^^^^^^^^^^^ | = help: consider: 0xb9f8_b322_c73a_c862 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac64.rs:271:19 | 271 | let mut c = w(0x8c0ea5053d4712a0); | ^^^^^^^^^^^^^^^^^^ | = help: consider: 0x8c0e_a505_3d47_12a0 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac64.rs:272:19 | 272 | let mut d = w(0xb29b2e824a595524); | ^^^^^^^^^^^^^^^^^^ | = help: consider: 0xb29b_2e82_4a59_5524 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac64.rs:273:19 | 273 | let mut e = w(0x82f053db8355e0ce); | ^^^^^^^^^^^^^^^^^^ | = help: consider: 0x82f0_53db_8355_e0ce = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac64.rs:274:19 | 274 | let mut f = w(0x48fe4a0fa5a09315); | ^^^^^^^^^^^^^^^^^^ | = help: consider: 0x48fe_4a0f_a5a0_9315 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac64.rs:275:19 | 275 | let mut g = w(0xae985bf2cbfc89ed); | ^^^^^^^^^^^^^^^^^^ | = help: consider: 0xae98_5bf2_cbfc_89ed = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/isaac64.rs:276:19 | 276 | let mut h = w(0x98f5704f6c44c0ab); | ^^^^^^^^^^^^^^^^^^ | = help: consider: 0x98f5_704f_6c44_c0ab = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: 5th binding whose name is just one char --> src/prng/isaac64.rs:307:8 | 307 | e: &mut w64, f: &mut w64, g: &mut w64, h: &mut w64) { | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 6th binding whose name is just one char --> src/prng/isaac64.rs:307:21 | 307 | e: &mut w64, f: &mut w64, g: &mut w64, h: &mut w64) { | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 7th binding whose name is just one char --> src/prng/isaac64.rs:307:34 | 307 | e: &mut w64, f: &mut w64, g: &mut w64, h: &mut w64) { | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: 8th binding whose name is just one char --> src/prng/isaac64.rs:307:47 | 307 | e: &mut w64, f: &mut w64, g: &mut w64, h: &mut w64) { | ^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#many_single_char_names warning: long literal lacking separators --> src/prng/xorshift.rs:53:18 | 53 | x: w(0x193a6754), | ^^^^^^^^^^ | = help: consider: 0x193a_6754 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/xorshift.rs:54:18 | 54 | y: w(0xa8a7d469), | ^^^^^^^^^^ | = help: consider: 0xa8a7_d469 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/xorshift.rs:55:18 | 55 | z: w(0x97830e05), | ^^^^^^^^^^ | = help: consider: 0x9783_0e05 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/prng/xorshift.rs:56:18 | 56 | w: w(0x113ba7bb), | ^^^^^^^^^^ | = help: consider: 0x113b_a7bb = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: unneeded return statement --> src/distributions/log_gamma.rs:50:5 | 50 | return log + (2.5066282746310005 * a / x).ln(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `log + (2.5066282746310005 * a / x).ln()` | = note: #[warn(needless_return)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_return warning: Constants have by default a `'static` lifetime --> src/distributions/other.rs:61:39 | 61 | const GEN_ASCII_STR_CHARSET: &'static [u8] = | -^^^^^^^----- help: consider removing `'static`: `&[u8]` | = note: #[warn(const_static_lifetime)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#const_static_lifetime warning: unneeded return statement --> src/distributions/mod.rs:323:9 | 323 | return self.items[idx + 1].item.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.items[idx + 1].item.clone()` | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_return warning: you should put `x_i` between ticks in the documentation --> src/distributions/mod.rs:333:17 | 333 | /// * `X`: the $x_i$ abscissae. | ^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `x_i` between ticks in the documentation --> src/distributions/mod.rs:334:50 | 334 | /// * `F`: precomputed values of the PDF at the $x_i$, (i.e. $f(x_i)$) | ^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `f(x_i` between ticks in the documentation --> src/distributions/mod.rs:334:63 | 334 | /// * `F`: precomputed values of the PDF at the $x_i$, (i.e. $f(x_i)$) | ^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `f(x_i` between ticks in the documentation --> src/distributions/mod.rs:335:40 | 335 | /// * `F_DIFF`: precomputed values of $f(x_i) - f(x_{i+1})$ | ^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `f(x_{i+1` between ticks in the documentation --> src/distributions/mod.rs:335:49 | 335 | /// * `F_DIFF`: precomputed values of $f(x_i) - f(x_{i+1})$ | ^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: long literal lacking separators --> src/jitter.rs:395:31 | 395 | const CONSTANT: u64 = 0x67452301efcdab89; | ^^^^^^^^^^^^^^^^^^ | = help: consider: 0x6745_2301_efcd_ab89 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> src/jitter.rs:400:25 | 400 | let mut mixer = 0x98badcfe10325476; | ^^^^^^^^^^^^^^^^^^ | = help: consider: 0x98ba_dcfe_1032_5476 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: you should put `OpenBSD` between ticks in the documentation --> src/os.rs:41:7 | 41 | /// - OpenBSD: calls `getentropy(2)`. | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `FreeBSD` between ticks in the documentation --> src/os.rs:42:7 | 42 | /// - FreeBSD: uses the `kern.arandom` `sysctl(2)` mib. | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `CloudABI` between ticks in the documentation --> src/os.rs:45:7 | 45 | /// - CloudABI: calls `random_get`. | ^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: returning the result of a let binding from a block. Consider returning the expression directly. --> src/reseeding.rs:179:13 | 179 | delay | ^^^^^ | = note: #[warn(let_and_return)] on by default note: this expression can be directly returned --> src/reseeding.rs:172:25 | 172 | let delay = match e.kind { | _________________________^ 173 | | ErrorKind::Transient => 0, 174 | | kind @ _ if kind.should_retry() => self.threshold >> 8, 175 | | _ => self.threshold, 176 | | }; | |_____________^ = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#let_and_return warning: you should put `HashMap` between ticks in the documentation --> src/seq.rs:166:33 | 166 | /// This is better than using a HashMap "cache" when `amount >= length / 2` since it does not | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `HashMap` between ticks in the documentation --> src/seq.rs:186:79 | 186 | /// This method performs a partial fisher-yates on a range of indices using a HashMap | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `1_000_000` between ticks in the documentation --> src/seq.rs:190:59 | 190 | /// `amount <<< length`, i.e. select 3 non-repeating from 1_000_000 | ^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: you should put `ChaCha` between ticks in the documentation --> src/lib.rs:241:13 | 241 | //! The ChaCha random number generator. | ^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: Constants have by default a `'static` lifetime --> src/lib.rs:714:39 | 714 | const GEN_ASCII_STR_CHARSET: &'static [u8] = | -^^^^^^^----- help: consider removing `'static`: `&[u8]` | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#const_static_lifetime warning: you should put `thread_rng` between ticks in the documentation --> src/lib.rs:917:55 | 917 | /// This will seed the generator with randomness from thread_rng. | ^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#doc_markdown warning: redundant closure found --> src/prng/chacha.rs:98:51 | 98 | BlockRng::::from_rng(rng).map(|result| ChaChaRng(result)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ChaChaRng` | = note: #[warn(redundant_closure)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#redundant_closure warning: you have declared `#[inline(always)]` on `next_u32`. This is usually a bad idea --> src/prng/hc128.rs:68:5 | 68 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = note: #[warn(inline_always)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: you have declared `#[inline(always)]` on `next_u64`. This is usually a bad idea --> src/prng/hc128.rs:73:5 | 73 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: redundant closure found --> src/prng/hc128.rs:95:50 | 95 | BlockRng::::from_rng(rng).map(|result| Hc128Rng(result)) | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Hc128Rng` | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#redundant_closure warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:128:39 | 128 | results[0] = self.step_p(cc+0, cc+1, ee+13, ee+6, ee+4); | ^^^^ | = note: #[warn(identity_op)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:131:53 | 131 | results[3] = self.step_p(cc+3, cc+4, cc+0, ee+9, ee+7); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:138:60 | 138 | results[10] = self.step_p(cc+10, cc+11, cc+7, cc+0, ee+14); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:140:67 | 140 | results[12] = self.step_p(cc+12, cc+13, cc+9, cc+2, cc+0); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `dd` --> src/prng/hc128.rs:143:46 | 143 | results[15] = self.step_p(cc+15, dd+0, cc+12, cc+5, cc+3); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:146:39 | 146 | results[0] = self.step_q(cc+0, cc+1, ee+13, ee+6, ee+4); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:149:53 | 149 | results[3] = self.step_q(cc+3, cc+4, cc+0, ee+9, ee+7); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:156:60 | 156 | results[10] = self.step_q(cc+10, cc+11, cc+7, cc+0, ee+14); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:158:67 | 158 | results[12] = self.step_q(cc+12, cc+13, cc+9, cc+2, cc+0); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `dd` --> src/prng/hc128.rs:161:46 | 161 | results[15] = self.step_q(cc+15, dd+0, cc+12, cc+5, cc+3); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: you have declared `#[inline(always)]` on `step_p`. This is usually a bad idea --> src/prng/hc128.rs:169:5 | 169 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: you have declared `#[inline(always)]` on `step_q`. This is usually a bad idea --> src/prng/hc128.rs:197:5 | 197 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:228:41 | 228 | self.t[cc+0] = self.step_p(cc+0, cc+1, ee+13, ee+6, ee+4); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:228:20 | 228 | self.t[cc+0] = self.step_p(cc+0, cc+1, ee+13, ee+6, ee+4); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:231:55 | 231 | self.t[cc+3] = self.step_p(cc+3, cc+4, cc+0, ee+9, ee+7); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:238:62 | 238 | self.t[cc+10] = self.step_p(cc+10, cc+11, cc+7, cc+0, ee+14); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:240:69 | 240 | self.t[cc+12] = self.step_p(cc+12, cc+13, cc+9, cc+2, cc+0); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `dd` --> src/prng/hc128.rs:243:48 | 243 | self.t[cc+15] = self.step_p(cc+15, dd+0, cc+12, cc+5, cc+3); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:246:45 | 246 | self.t[cc+512+0] = self.step_q(cc+0, cc+1, ee+13, ee+6, ee+4); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc+512` --> src/prng/hc128.rs:246:20 | 246 | self.t[cc+512+0] = self.step_q(cc+0, cc+1, ee+13, ee+6, ee+4); | ^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:249:59 | 249 | self.t[cc+512+3] = self.step_q(cc+3, cc+4, cc+0, ee+9, ee+7); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:256:66 | 256 | self.t[cc+512+10] = self.step_q(cc+10, cc+11, cc+7, cc+0, ee+14); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `cc` --> src/prng/hc128.rs:258:73 | 258 | self.t[cc+512+12] = self.step_q(cc+12, cc+13, cc+9, cc+2, cc+0); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `dd` --> src/prng/hc128.rs:261:52 | 261 | self.t[cc+512+15] = self.step_q(cc+15, dd+0, cc+12, cc+5, cc+3); | ^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `i` --> src/prng/isaac.rs:197:58 | 197 | rngstep(self, a ^ (a << 13), &mut a, &mut b, i + 0, m, m2); | ^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `i` --> src/prng/isaac.rs:206:58 | 206 | rngstep(self, a ^ (a << 13), &mut a, &mut b, i + 0, m, m2); | ^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: passing a unit value to a function --> src/prng/isaac.rs:256:12 | 256 | Ok(self.fill_bytes(dest)) | ^^^^^^^^^^^^^^^^^^^^^ | = note: #[warn(unit_arg)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unit_arg help: if you intended to pass a unit value, use a unit literal instead | 256 | Ok(()) | ^^ warning: this function has too many arguments (8/7) --> src/prng/isaac.rs:330:1 | 330 | / fn mix(a: &mut w32, b: &mut w32, c: &mut w32, d: &mut w32, 331 | | e: &mut w32, f: &mut w32, g: &mut w32, h: &mut w32) { 332 | | *a ^= *b << 11; *d += *a; *b += *c; 333 | | *b ^= *c >> 2; *e += *b; *c += *d; ... | 339 | | *h ^= *a >> 9; *c += *h; *a += *b; 340 | | } | |_^ | = note: #[warn(too_many_arguments)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#too_many_arguments warning: the operation is ineffective. Consider reducing it to `i` --> src/prng/isaac64.rs:182:61 | 182 | rngstep(self, !(a ^ (a << 21)), &mut a, &mut b, i + 0, m, m2); | ^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: the operation is ineffective. Consider reducing it to `i` --> src/prng/isaac64.rs:191:61 | 191 | rngstep(self, !(a ^ (a << 21)), &mut a, &mut b, i + 0, m, m2); | ^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#identity_op warning: passing a unit value to a function --> src/prng/isaac64.rs:260:12 | 260 | Ok(self.fill_bytes(dest)) | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unit_arg help: if you intended to pass a unit value, use a unit literal instead | 260 | Ok(()) | ^^ warning: this function has too many arguments (8/7) --> src/prng/isaac64.rs:306:1 | 306 | / fn mix(a: &mut w64, b: &mut w64, c: &mut w64, d: &mut w64, 307 | | e: &mut w64, f: &mut w64, g: &mut w64, h: &mut w64) { 308 | | *a -= *e; *f ^= *h >> 9; *h += *a; 309 | | *b -= *f; *g ^= *a << 9; *a += *b; ... | 315 | | *h -= *d; *e ^= *g << 14; *g += *h; 316 | | } | |_^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#too_many_arguments warning: passing a unit value to a function --> src/prng/xorshift.rs:83:12 | 83 | Ok(self.fill_bytes(dest)) | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unit_arg help: if you intended to pass a unit value, use a unit literal instead | 83 | Ok(()) | ^^ warning: methods called `new` usually return `Self` --> src/distributions/range.rs:65:5 | 65 | / pub fn new(low: X, high: X) -> Range { 66 | | assert!(low < high, "Range::new called with `low >= high`"); 67 | | Range { inner: RangeImpl::new(low, high) } 68 | | } | |_____^ | = note: #[warn(new_ret_no_self)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#new_ret_no_self warning: casting u8 to u32 may become silently lossy if types change --> src/distributions/range.rs:270:29 | 270 | let range = self.range as $unsigned as $u_large; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.range as $unsigned)` ... 322 | range_int_impl! { i8, i8, u8, i32, u32 } | ---------------------------------------- in this macro invocation | = note: #[warn(cast_lossless)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting i8 to i32 may become silently lossy if types change --> src/distributions/range.rs:277:45 | 277 | let zone = self.zone as $signed as $i_large as $u_large; | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.zone)` ... 322 | range_int_impl! { i8, i8, u8, i32, u32 } | ---------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u32 may become silently lossy if types change --> src/distributions/range.rs:270:29 | 270 | let range = self.range as $unsigned as $u_large; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.range as $unsigned)` ... 323 | range_int_impl! { i16, i16, u16, i32, u32 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting i16 to i32 may become silently lossy if types change --> src/distributions/range.rs:277:45 | 277 | let zone = self.zone as $signed as $i_large as $u_large; | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.zone)` ... 323 | range_int_impl! { i16, i16, u16, i32, u32 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u32 may become silently lossy if types change --> src/distributions/range.rs:298:50 | 298 | if ::core::$unsigned::MAX <= ::core::u16::MAX as $unsigned { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(::core::u16::MAX)` ... 324 | range_int_impl! { i32, i32, u32, i32, u32 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u64 may become silently lossy if types change --> src/distributions/range.rs:298:50 | 298 | if ::core::$unsigned::MAX <= ::core::u16::MAX as $unsigned { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(::core::u16::MAX)` ... 325 | range_int_impl! { i64, i64, u64, i64, u64 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u8 to u32 may become silently lossy if types change --> src/distributions/range.rs:250:29 | 250 | let range = (high as $u_large) | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(high)` ... 329 | range_int_impl! { u8, i8, u8, i32, u32 } | ---------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u8 to u32 may become silently lossy if types change --> src/distributions/range.rs:251:43 | 251 | .wrapping_sub(low as $u_large) | ^^^^^^^^^^^^^^^ help: try: `u32::from(low)` ... 329 | range_int_impl! { u8, i8, u8, i32, u32 } | ---------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u8 to u32 may become silently lossy if types change --> src/distributions/range.rs:270:29 | 270 | let range = self.range as $unsigned as $u_large; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.range as $unsigned)` ... 329 | range_int_impl! { u8, i8, u8, i32, u32 } | ---------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting i8 to i32 may become silently lossy if types change --> src/distributions/range.rs:277:45 | 277 | let zone = self.zone as $signed as $i_large as $u_large; | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.zone)` ... 329 | range_int_impl! { u8, i8, u8, i32, u32 } | ---------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u8 to u32 may become silently lossy if types change --> src/distributions/range.rs:295:29 | 295 | let range = (high as $u_large) | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(high)` ... 329 | range_int_impl! { u8, i8, u8, i32, u32 } | ---------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u8 to u32 may become silently lossy if types change --> src/distributions/range.rs:296:43 | 296 | .wrapping_sub(low as $u_large); | ^^^^^^^^^^^^^^^ help: try: `u32::from(low)` ... 329 | range_int_impl! { u8, i8, u8, i32, u32 } | ---------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u32 may become silently lossy if types change --> src/distributions/range.rs:250:29 | 250 | let range = (high as $u_large) | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(high)` ... 330 | range_int_impl! { u16, i16, u16, i32, u32 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u32 may become silently lossy if types change --> src/distributions/range.rs:251:43 | 251 | .wrapping_sub(low as $u_large) | ^^^^^^^^^^^^^^^ help: try: `u32::from(low)` ... 330 | range_int_impl! { u16, i16, u16, i32, u32 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u32 may become silently lossy if types change --> src/distributions/range.rs:270:29 | 270 | let range = self.range as $unsigned as $u_large; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.range as $unsigned)` ... 330 | range_int_impl! { u16, i16, u16, i32, u32 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting i16 to i32 may become silently lossy if types change --> src/distributions/range.rs:277:45 | 277 | let zone = self.zone as $signed as $i_large as $u_large; | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.zone)` ... 330 | range_int_impl! { u16, i16, u16, i32, u32 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u32 may become silently lossy if types change --> src/distributions/range.rs:295:29 | 295 | let range = (high as $u_large) | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(high)` ... 330 | range_int_impl! { u16, i16, u16, i32, u32 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u32 may become silently lossy if types change --> src/distributions/range.rs:296:43 | 296 | .wrapping_sub(low as $u_large); | ^^^^^^^^^^^^^^^ help: try: `u32::from(low)` ... 330 | range_int_impl! { u16, i16, u16, i32, u32 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u32 may become silently lossy if types change --> src/distributions/range.rs:298:50 | 298 | if ::core::$unsigned::MAX <= ::core::u16::MAX as $unsigned { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(::core::u16::MAX)` ... 331 | range_int_impl! { u32, i32, u32, i32, u32 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u64 may become silently lossy if types change --> src/distributions/range.rs:298:50 | 298 | if ::core::$unsigned::MAX <= ::core::u16::MAX as $unsigned { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(::core::u16::MAX)` ... 332 | range_int_impl! { u64, i64, u64, i64, u64 } | ------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u8 to u16 may become silently lossy if types change --> src/distributions/range.rs:351:27 | 351 | let tmp = (self as $wide) * (x as $wide); | ^^^^^^^^^^^^^^^ help: try: `u16::from(self)` ... 358 | wmul_impl! { u8, u16, 8 } | ------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u8 to u16 may become silently lossy if types change --> src/distributions/range.rs:351:45 | 351 | let tmp = (self as $wide) * (x as $wide); | ^^^^^^^^^^^^ help: try: `u16::from(x)` ... 358 | wmul_impl! { u8, u16, 8 } | ------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u32 may become silently lossy if types change --> src/distributions/range.rs:351:27 | 351 | let tmp = (self as $wide) * (x as $wide); | ^^^^^^^^^^^^^^^ help: try: `u32::from(self)` ... 359 | wmul_impl! { u16, u32, 16 } | --------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u16 to u32 may become silently lossy if types change --> src/distributions/range.rs:351:45 | 351 | let tmp = (self as $wide) * (x as $wide); | ^^^^^^^^^^^^ help: try: `u32::from(x)` ... 359 | wmul_impl! { u16, u32, 16 } | --------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u32 to u64 may become silently lossy if types change --> src/distributions/range.rs:351:27 | 351 | let tmp = (self as $wide) * (x as $wide); | ^^^^^^^^^^^^^^^ help: try: `u64::from(self)` ... 360 | wmul_impl! { u32, u64, 32 } | --------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting u32 to u64 may become silently lossy if types change --> src/distributions/range.rs:351:45 | 351 | let tmp = (self as $wide) * (x as $wide); | ^^^^^^^^^^^^ help: try: `u64::from(x)` ... 360 | wmul_impl! { u32, u64, 32 } | --------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: strict comparison of f32 or f64 --> src/distributions/gamma.rs:105:23 | 105 | let repr = if shape == 1.0 { | ^^^^^^^^^^^^ help: consider comparing them within some error: `(shape - 1.0).abs() < error` | = note: #[warn(float_cmp)] on by default note: std::f32::EPSILON and std::f64::EPSILON are available. --> src/distributions/gamma.rs:105:23 | 105 | let repr = if shape == 1.0 { | ^^^^^^^^^^^^ = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#float_cmp warning: strict comparison of f32 or f64 --> src/distributions/gamma.rs:208:23 | 208 | let repr = if k == 1.0 { | ^^^^^^^^ help: consider comparing them within some error: `(k - 1.0).abs() < error` | note: std::f32::EPSILON and std::f64::EPSILON are available. --> src/distributions/gamma.rs:208:23 | 208 | let repr = if k == 1.0 { | ^^^^^^^^ = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#float_cmp warning: strict comparison of f32 or f64 --> src/distributions/binomial.rs:119:12 | 119 | if p != self.p { | ^^^^^^^^^^^ help: consider comparing them within some error: `(p - self.p).abs() < error` | note: std::f32::EPSILON and std::f64::EPSILON are available. --> src/distributions/binomial.rs:119:12 | 119 | if p != self.p { | ^^^^^^^^^^^ = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#float_cmp warning: use of `#[inline]` on trait method `into_float_with_exponent` which has no body --> src/distributions/float.rs:28:5 | 28 | #[inline(always)] | _____-^^^^^^^^^^^^^^^^ 29 | | fn into_float_with_exponent(self, exponent: i32) -> Self::F; | |____- help: remove | = note: #[warn(inline_fn_without_body)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_fn_without_body warning: transmute from a `u32` to a `f32` --> src/distributions/float.rs:42:26 | 42 | unsafe { mem::transmute(self | exponent_bits) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(self | exponent_bits)` ... 69 | float_impls! { f32, u32, 23, 127, next_u32 } | -------------------------------------------- in this macro invocation | = note: #[warn(transmute_int_to_float)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#transmute_int_to_float warning: transmute from a `u64` to a `f64` --> src/distributions/float.rs:42:26 | 42 | unsafe { mem::transmute(self | exponent_bits) } | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(self | exponent_bits)` ... 70 | float_impls! { f64, u64, 52, 1023, next_u64 } | --------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#transmute_int_to_float warning: the loop variable `j` is only used to index `coefficients`. --> src/distributions/log_gamma.rs:42:14 | 42 | for j in 0..6 { | ^^^^ | = note: #[warn(needless_range_loop)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_range_loop help: consider using an iterator | 42 | for in coefficients.iter().take(6) { | warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` --> src/distributions/other.rs:48:13 | 48 | / match char::from_u32(range.sample(rng)) { 49 | | Some(c) => return c, 50 | | // About 0.2% of numbers in the range 0..0x110000 are invalid 51 | | // codepoints (surrogates). 52 | | None => {} 53 | | } | |_____________^ help: try this: `if let Some(c) = char::from_u32(range.sample(rng)) { return c }` | = note: #[warn(single_match)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#single_match warning: manual implementation of an assign operation --> src/jitter.rs:241:13 | 241 | time = time >> n_bits; | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time >>= n_bits` | = note: #[warn(assign_op_pattern)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#assign_op_pattern warning: manual implementation of an assign operation --> src/jitter.rs:262:17 | 262 | tmp = tmp >> (64 - 1); | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tmp >>= (64 - 1)` | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#assign_op_pattern warning: passing a unit value to a function --> src/jitter.rs:782:12 | 782 | Ok(self.fill_bytes(dest)) | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unit_arg help: if you intended to pass a unit value, use a unit literal instead | 782 | Ok(()) | ^^ warning: passing a unit value to a function --> src/mock.rs:59:12 | 59 | Ok(self.fill_bytes(dest)) | ^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unit_arg help: if you intended to pass a unit value, use a unit literal instead | 59 | Ok(()) | ^^ warning: casting u32 to u64 may become silently lossy if types change --> src/os.rs:87:52 | 87 | let wait_dur = time::Duration::from_millis(WAIT_DUR_MS as u64); | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(WAIT_DUR_MS)` | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: length comparison to zero --> src/read.rs:66:12 | 66 | if dest.len() == 0 { return Ok(()); } | ^^^^^^^^^^^^^^^ help: using `is_empty` is more concise: `dest.is_empty()` | = note: #[warn(len_zero)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#len_zero warning: you have declared `#[inline(always)]` on `next_u32`. This is usually a bad idea --> src/reseeding.rs:102:5 | 102 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: you have declared `#[inline(always)]` on `next_u64`. This is usually a bad idea --> src/reseeding.rs:107:5 | 107 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: the `kind @ _` pattern can be written as just `kind` --> src/reseeding.rs:174:17 | 174 | kind @ _ if kind.should_retry() => self.threshold >> 8, | ^^^^^^^^ | = note: #[warn(redundant_pattern)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#redundant_pattern warning: this looks like you are swapping elements of `indices` manually --> src/seq.rs:176:9 | 176 | / let tmp = indices[i]; 177 | | indices[i] = indices[j]; 178 | | indices[j] = tmp; | |________________________^ help: try: `indices.swap(i, j)` | = note: #[warn(manual_swap)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#manual_swap warning: you should consider adding a `Default` implementation for `entropy_rng::EntropyRng` --> src/entropy_rng.rs:53:5 | 53 | / pub fn new() -> Self { 54 | | EntropyRng { rng: EntropySource::None } 55 | | } | |_____^ | = note: #[warn(new_without_default)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#new_without_default help: try this | 47 | impl Default for entropy_rng::EntropyRng { 48 | fn default() -> Self { 49 | Self::new() 50 | } 51 | } | warning: you have declared `#[inline(always)]` on `next_u32`. This is usually a bad idea --> src/thread_rng.rs:100:5 | 100 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: you have declared `#[inline(always)]` on `next_u64`. This is usually a bad idea --> src/thread_rng.rs:105:5 | 105 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: casting u32 to f64 may become silently lossy if types change --> src/lib.rs:514:26 | 514 | let p_int = (p * core::u32::MAX as f64) as u32; | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(core::u32::MAX)` | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:607:5 | 607 | fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: #[warn(needless_lifetimes)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:614:5 | 614 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 615 | | self 616 | | } | |_____^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:624:13 | 624 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 625 | | unsafe { 626 | | slice::from_raw_parts_mut(&mut self[0] 627 | | as *mut $t ... | 631 | | } 632 | | } | |_____________^ ... 643 | impl_as_byte_slice!(u16); | ------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:624:13 | 624 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 625 | | unsafe { 626 | | slice::from_raw_parts_mut(&mut self[0] 627 | | as *mut $t ... | 631 | | } 632 | | } | |_____________^ ... 644 | impl_as_byte_slice!(u32); | ------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:624:13 | 624 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 625 | | unsafe { 626 | | slice::from_raw_parts_mut(&mut self[0] 627 | | as *mut $t ... | 631 | | } 632 | | } | |_____________^ ... 645 | impl_as_byte_slice!(u64); | ------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:624:13 | 624 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 625 | | unsafe { 626 | | slice::from_raw_parts_mut(&mut self[0] 627 | | as *mut $t ... | 631 | | } 632 | | } | |_____________^ ... 647 | impl_as_byte_slice!(usize); | --------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:624:13 | 624 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 625 | | unsafe { 626 | | slice::from_raw_parts_mut(&mut self[0] 627 | | as *mut $t ... | 631 | | } 632 | | } | |_____________^ ... 648 | impl_as_byte_slice!(i8); | ------------------------ in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:624:13 | 624 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 625 | | unsafe { 626 | | slice::from_raw_parts_mut(&mut self[0] 627 | | as *mut $t ... | 631 | | } 632 | | } | |_____________^ ... 649 | impl_as_byte_slice!(i16); | ------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:624:13 | 624 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 625 | | unsafe { 626 | | slice::from_raw_parts_mut(&mut self[0] 627 | | as *mut $t ... | 631 | | } 632 | | } | |_____________^ ... 650 | impl_as_byte_slice!(i32); | ------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:624:13 | 624 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 625 | | unsafe { 626 | | slice::from_raw_parts_mut(&mut self[0] 627 | | as *mut $t ... | 631 | | } 632 | | } | |_____________^ ... 651 | impl_as_byte_slice!(i64); | ------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:624:13 | 624 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 625 | | unsafe { 626 | | slice::from_raw_parts_mut(&mut self[0] 627 | | as *mut $t ... | 631 | | } 632 | | } | |_____________^ ... 653 | impl_as_byte_slice!(isize); | --------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: explicit lifetimes given in parameter types where they could be elided --> src/lib.rs:661:13 | 661 | / fn as_byte_slice_mut<'a>(&'a mut self) -> &'a mut [u8] { 662 | | self[..].as_byte_slice_mut() 663 | | } | |_____________^ ... 671 | impl_as_byte_slice_arrays!(32, N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,N,); | ------------------------------------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#needless_lifetimes warning: you have declared `#[inline(always)]` on `next_u32`. This is usually a bad idea --> src/lib.rs:796:5 | 796 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: you have declared `#[inline(always)]` on `next_u64`. This is usually a bad idea --> src/lib.rs:801:5 | 801 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: redundant closure found --> src/lib.rs:823:37 | 823 | Hc128Rng::from_rng(rng).map(|result| StdRng(result)) | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `StdRng` | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#redundant_closure warning: you have declared `#[inline(always)]` on `next_u32`. This is usually a bad idea --> src/lib.rs:877:5 | 877 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: you have declared `#[inline(always)]` on `next_u64`. This is usually a bad idea --> src/lib.rs:882:5 | 882 | #[inline(always)] | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#inline_always warning: redundant closure found --> src/lib.rs:904:40 | 904 | XorShiftRng::from_rng(rng).map(|result| SmallRng(result)) | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmallRng` | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#redundant_closure Finished dev [unoptimized + debuginfo] target(s) in 5.3 secs example: monte-carlo Downloading bincode v1.0.0 Downloading serde v1.0.36 Downloading byteorder v1.2.1 Compiling byteorder v1.2.1 Compiling serde v1.0.36 Compiling rand v0.5.0-pre.0 (file:///Users/abreis/Downloads/rand) Compiling bincode v1.0.0 warning: casting i32 to f64 may become silently lossy if types change --> examples/monte-carlo.rs:51:43 | 51 | println!("π is approximately {}", 4. * (in_circle as f64) / (total as f64)); | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(in_circle)` | = note: #[warn(cast_lossless)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless warning: casting i32 to f64 may become silently lossy if types change --> examples/monte-carlo.rs:51:64 | 51 | println!("π is approximately {}", 4. * (in_circle as f64) / (total as f64)); | ^^^^^^^^^^^^^^ help: try: `f64::from(total)` | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#cast_lossless Finished dev [unoptimized + debuginfo] target(s) in 12.97 secs example: monty-hall Compiling rand v0.5.0-pre.0 (file:///Users/abreis/Downloads/rand) warning: long literal lacking separators --> examples/monty-hall.rs:83:27 | 83 | let num_simulations = 10000; | ^^^^^ | = note: #[warn(unreadable_literal)] on by default = help: consider: 10_000 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal Finished dev [unoptimized + debuginfo] target(s) in 1.33 secs bench: misc Compiling rand v0.5.0-pre.0 (file:///Users/abreis/Downloads/rand) Finished dev [unoptimized + debuginfo] target(s) in 1.96 secs bench: distributions Compiling rand v0.5.0-pre.0 (file:///Users/abreis/Downloads/rand) warning: long literal lacking separators --> benches/distributions.rs:77:51 | 77 | distr_int!(distr_range_i64, i64, Range::new(3i64, 12345678901234)); | ^^^^^^^^^^^^^^ | = note: #[warn(unreadable_literal)] on by default = help: consider: 12_345_678_901_234 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: long literal lacking separators --> benches/distributions.rs:134:42 | 134 | gen_range_int!(gen_range_i64, i64, 3i64, 12345678901234); | ^^^^^^^^^^^^^^ | = help: consider: 12_345_678_901_234 = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#unreadable_literal warning: manual implementation of an assign operation --> benches/distributions.rs:46:21 | 46 | accum = accum + x; | ^^^^^^^^^^^^^^^^^ help: replace it with: `accum += x` ... 81 | distr_float!(distr_range_f32, f32, Range::new(2.26f32, 2.319)); | --------------------------------------------------------------- in this macro invocation | = note: #[warn(assign_op_pattern)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#assign_op_pattern warning: manual implementation of an assign operation --> benches/distributions.rs:46:21 | 46 | accum = accum + x; | ^^^^^^^^^^^^^^^^^ help: replace it with: `accum += x` ... 82 | distr_float!(distr_range_f64, f64, Range::new(2.26f64, 2.319)); | --------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#assign_op_pattern warning: manual implementation of an assign operation --> benches/distributions.rs:46:21 | 46 | accum = accum + x; | ^^^^^^^^^^^^^^^^^ help: replace it with: `accum += x` ... 96 | distr_float!(distr_uniform_f32, f32, Uniform); | ---------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#assign_op_pattern warning: manual implementation of an assign operation --> benches/distributions.rs:46:21 | 46 | accum = accum + x; | ^^^^^^^^^^^^^^^^^ help: replace it with: `accum += x` ... 97 | distr_float!(distr_uniform_f64, f64, Uniform); | ---------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#assign_op_pattern warning: approximate value of `f{32, 64}::consts::E` found. Consider using it directly --> benches/distributions.rs:100:39 | 100 | distr_float!(distr_exp, f64, Exp::new(2.71828 * 3.14159)); | ^^^^^^^ | = note: #[warn(approx_constant)] on by default = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#approx_constant warning: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly --> benches/distributions.rs:100:49 | 100 | distr_float!(distr_exp, f64, Exp::new(2.71828 * 3.14159)); | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#approx_constant warning: manual implementation of an assign operation --> benches/distributions.rs:46:21 | 46 | accum = accum + x; | ^^^^^^^^^^^^^^^^^ help: replace it with: `accum += x` ... 100 | distr_float!(distr_exp, f64, Exp::new(2.71828 * 3.14159)); | ---------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#assign_op_pattern warning: approximate value of `f{32, 64}::consts::E` found. Consider using it directly --> benches/distributions.rs:101:46 | 101 | distr_float!(distr_normal, f64, Normal::new(-2.71828, 3.14159)); | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#approx_constant warning: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly --> benches/distributions.rs:101:55 | 101 | distr_float!(distr_normal, f64, Normal::new(-2.71828, 3.14159)); | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#approx_constant warning: manual implementation of an assign operation --> benches/distributions.rs:46:21 | 46 | accum = accum + x; | ^^^^^^^^^^^^^^^^^ help: replace it with: `accum += x` ... 101 | distr_float!(distr_normal, f64, Normal::new(-2.71828, 3.14159)); | ---------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#assign_op_pattern warning: approximate value of `f{32, 64}::consts::E` found. Consider using it directly --> benches/distributions.rs:102:53 | 102 | distr_float!(distr_log_normal, f64, LogNormal::new(-2.71828, 3.14159)); | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#approx_constant warning: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly --> benches/distributions.rs:102:62 | 102 | distr_float!(distr_log_normal, f64, LogNormal::new(-2.71828, 3.14159)); | ^^^^^^^ | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#approx_constant warning: manual implementation of an assign operation --> benches/distributions.rs:46:21 | 46 | accum = accum + x; | ^^^^^^^^^^^^^^^^^ help: replace it with: `accum += x` ... 102 | distr_float!(distr_log_normal, f64, LogNormal::new(-2.71828, 3.14159)); | ----------------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#assign_op_pattern warning: manual implementation of an assign operation --> benches/distributions.rs:46:21 | 46 | accum = accum + x; | ^^^^^^^^^^^^^^^^^ help: replace it with: `accum += x` ... 103 | distr_float!(distr_gamma_large_shape, f64, Gamma::new(10., 1.0)); | ----------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#assign_op_pattern warning: manual implementation of an assign operation --> benches/distributions.rs:46:21 | 46 | accum = accum + x; | ^^^^^^^^^^^^^^^^^ help: replace it with: `accum += x` ... 104 | distr_float!(distr_gamma_small_shape, f64, Gamma::new(0.1, 1.0)); | ----------------------------------------------------------------- in this macro invocation | = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.186/index.html#assign_op_pattern Finished dev [unoptimized + debuginfo] target(s) in 2.14 secs bench: generators Compiling rand v0.5.0-pre.0 (file:///Users/abreis/Downloads/rand) Finished dev [unoptimized + debuginfo] target(s) in 3.37 secs