Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider examples for "failure" crate? #370

Open
ludwigpacifici opened this issue Nov 23, 2017 · 7 comments
Open

Consider examples for "failure" crate? #370

ludwigpacifici opened this issue Nov 23, 2017 · 7 comments

Comments

@ludwigpacifici
Copy link
Contributor

Recently, Failure was announced (discussions here, also here). Is it too early to think about recipes (equivalent to error-chain) for it?

@budziq
Copy link
Collaborator

budziq commented Nov 24, 2017

@ludwigpacifici Thanks for pointing this out!
Imho we should wait a little before Failure gets more traction and possibly matures a little.
The error-chain crate had a lot of time to mature and enjoyed wide adoption before it got included in cookbook. I'd not want to promote a crate before both community and author are "confident enough" in the crate API stability (which I'm guessing is quite early for Failure)

@withoutboats might have some thoughts on the subject as far as I know they are working with @aturon on proposed crate list for the cookbook.

@AndyGauge
Copy link
Collaborator

So failure has taken the de facto error handling position in the ecosystem. I think a rip and replace would be reasonable. Here's something kinda official rust-lang-deprecated/failure#181

@budziq
Copy link
Collaborator

budziq commented Jul 13, 2018

While failure has gained some popularity I'm not entirely sure it has much development traction as its repo is not super active especially in regard to 1.0. Post the initial release it has been barely updated in crates.io with no releases since Nov 30, 2017 and it looks barely more active than error_chain.

Also failure work has been marked as "stalled" in rust release management worksheet presumably boats being occupied with some higher value targets at the moment.

With error_chain still having 2x daily downloads than failure I don't think that we should just decide by ourselves that the idiomatic and production ready error handling in rust is now all about failure.
I'd like to invite ecosystem-wg to the discussion
ping @KodrAus

@Dylan-DPC-zz
Copy link

While failure has gained some popularity I'm not entirely sure it has much development traction as its repo is not super active especially in regard to 1.0.

Failure is getting a new team soon which will help the crate get some traction and work towards 1.0 and beyond.

@budziq
Copy link
Collaborator

budziq commented Jul 13, 2018

Thanks @Dylan-DPC!

I can see two issues here:

  • failure's design is in flux and I feel inclined towards waiting untill things take shape (the same reason why there is no tokio/async chapter yet)
  • the issue raised in List of foundational / core crates ecosystem-wg#22. how do we choose the best/most idiomatic crate when there are several equivalent contenders?

@mulkieran
Copy link

failure had a new release fairly recently: https://github.com/rust-lang-nursery/failure/releases/tag/0.1.3.

and it is closing the gap on error-chain wrt. daily and all-time downloads.

My real goal is to get failure into the Rust playground, but I see we have a chicken and egg problem here ;-(

@najamelan
Copy link

Failure has been deprecated, so this can probably be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants