Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to sqlx #82

Closed
Kobzol opened this issue May 3, 2024 · 3 comments
Closed

Switch to sqlx #82

Kobzol opened this issue May 3, 2024 · 3 comments

Comments

@Kobzol
Copy link
Contributor

Kobzol commented May 3, 2024

I don't think that SeaORM is pulling its weight at the moment. Bors requires only a relatively simple database, and full ORM seems like an overkill to me. SeaORM requires us to have additional two crates in the workspace, juggle three different types per DB table, and it's not obvious to me what commands it executes and how it manages migrations.

For sake of transparency and easier understanding of what exactly we run against the DB, I would suggest to switch to sqlx.

@vohoanglong0107
Copy link
Contributor

Do we need to migrate gradually from SeaORM to sqlx, or can we can just drop SeaORM and build sqlx models from scratch?

@Kobzol
Copy link
Contributor Author

Kobzol commented May 4, 2024

We don't need to do any incremental migration, we can just nuke the current DB, it's mostly empty anyway.

@Kobzol
Copy link
Contributor Author

Kobzol commented May 21, 2024

Fixed by #87. Thanks!

@Kobzol Kobzol closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants