Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git doesn’t ask for SSH key password with net.git-fetch-with-cli = true under Windows #10925

Closed
pwnorbitals opened this issue Aug 2, 2022 · 1 comment
Labels
A-git Area: anything dealing with git C-bug Category: bug O-windows OS: Windows

Comments

@pwnorbitals
Copy link

pwnorbitals commented Aug 2, 2022

Problem

I’m using private repositories like this : crate = { git = "ssh://git@gitlab.mycompany.com/namespace/crate.git" }

In order to allow for SSH authentication, I’m turning on the feature net.git-fetch-with-cli = true through .cargo/config.toml.

It all works fine under Linux (WSL2) and asks for the private key’s password through stdin, but not under Windows.

Steps

  1. Use Windows 10
  2. Use a private repository like shown in problem description
  3. Use a password-protected SSH key
  4. Activate net.git-fetch-with-cli
  5. cargo build fails

Possible Solution(s)

Might be in src/cargo/sources/git/utils.rs:880 or further down in cargo-util/src/process_builder.rs:284

Notes

Today is the first day of the rest of your life

Version

cargo 1.64.0-nightly (85b500cca 2022-07-24)
release: 1.64.0-nightly
commit-hash: 85b500ccad8cd0b63995fd94a03ddd4b83f7905b
commit-date: 2022-07-24
host: x86_64-pc-windows-gnu
libgit2: 1.4.2 (sys:0.14.2 vendored)
libcurl: 7.83.1-DEV (sys:0.4.55+curl-7.83.1 vendored ssl:Schannel)
os: Windows 10.0.19044 (Windows 10 Pro) [64-bit]
@pwnorbitals pwnorbitals added the C-bug Category: bug label Aug 2, 2022
@ehuss ehuss added A-git Area: anything dealing with git O-windows OS: Windows labels Aug 13, 2022
@ehuss
Copy link
Contributor

ehuss commented Apr 3, 2023

Closing as this appears to be fixed by #11579.

@ehuss ehuss closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-git Area: anything dealing with git C-bug Category: bug O-windows OS: Windows
Projects
None yet
Development

No branches or pull requests

2 participants