Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for trim-paths RFC 3127 #12137

Open
1 of 6 tasks
ehuss opened this issue May 13, 2023 · 8 comments
Open
1 of 6 tasks

Tracking Issue for trim-paths RFC 3127 #12137

ehuss opened this issue May 13, 2023 · 8 comments
Assignees
Labels
A-profiles Area: profiles C-tracking-issue Category: A tracking issue for something unstable. S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review S-waiting-on-feedback Status: An implemented feature is waiting on community feedback for bugs or design concerns. Z-trim-paths Nightly: path sanitization

Comments

@ehuss
Copy link
Contributor

ehuss commented May 13, 2023

Summary

RFC: #3127
Documentation: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#profile-trim-paths-option
Issues: Z-trim-paths Nightly: path sanitization
rustc tracking issue: rust-lang/rust#111540

This adds a new profile setting (among other things) to control how paths are sanitized in the resulting binary.

Unresolved Issues

Future Extensions

No response

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Implementation history

@ehuss ehuss added S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing. C-tracking-issue Category: A tracking issue for something unstable. Z-trim-paths Nightly: path sanitization labels May 13, 2023
@weihanglo weihanglo added the E-hard Experience: Hard label May 27, 2023
@weihanglo weihanglo self-assigned this Oct 31, 2023
@weihanglo weihanglo added S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review S-waiting-on-feedback Status: An implemented feature is waiting on community feedback for bugs or design concerns. A-profiles Area: profiles and removed S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing. E-hard Experience: Hard labels Oct 31, 2023
@epage
Copy link
Contributor

epage commented May 29, 2024

@joshtriplett
Copy link
Member

Is this working on Linux, well enough that we could ship it for Linux without promising macOS support?

@weihanglo
Copy link
Member

This is the latest status of it on rustc side: rust-lang/rust#111540 (comment), which the new remap rule in the conclusion is implemented. I've updated the unresolved issues section in this tracking issue.

@weihanglo
Copy link
Member

Status update:

@weihanglo
Copy link
Member

weihanglo commented Jun 10, 2024

rust-lang/rust#107099 is just merged, so should be able to support for rustdoc.

Edit: need to adjust cargo to pass --remap-path-prefix to rustdoc invocations.

@weihanglo
Copy link
Member

Updated:

That potentially blocks this, if we would like to see -Ztrim-paths supports also for rustdoc invocations.

@liciana24
Copy link

Updated:

That potentially blocks this, if we would like to see -Ztrim-paths supports also for rustdoc invocations.

both of those linked are closed/merged what is left blocking to get trimpaths working?

@weihanglo
Copy link
Member

both of those linked are closed/merged what is left blocking to get trimpaths working?

@liciana24 There are some unresolved issues listed in the PR description I just updated.

It should minimally work. Any feedback of it not working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-profiles Area: profiles C-tracking-issue Category: A tracking issue for something unstable. S-accepted Status: Issue or feature is accepted, and has a team member available to help mentor or review S-waiting-on-feedback Status: An implemented feature is waiting on community feedback for bugs or design concerns. Z-trim-paths Nightly: path sanitization
Projects
Status: In Progress
Development

No branches or pull requests

5 participants