Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider whether --keep-going deserves a short flag (-k?) #12571

Closed
dtolnay opened this issue Aug 26, 2023 · 6 comments
Closed

Consider whether --keep-going deserves a short flag (-k?) #12571

dtolnay opened this issue Aug 26, 2023 · 6 comments
Labels
A-cli Area: Command-line interface, option parsing, etc. C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` E-easy Experience: Easy S-needs-team-input Status: Needs input from team on whether/how to proceed.

Comments

@dtolnay
Copy link
Member

dtolnay commented Aug 26, 2023

This issue is to track a suggestion brought forth by @joshtriplett in #10383 (comment).

"I'd also love to see a -k shorthand added, similar to make -k; the nature of this option is such that it'd should be easy for people to invoke."

As part of stabilization of --keep-going in #10496 (comment), it was decided to stabilize without -k and defer a thorougher consideration of -k to a followup issue.

"For -k short alias, I'll create an issue for it after the FCP."

@dtolnay dtolnay added C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-triage Status: This issue is waiting on initial triage. labels Aug 26, 2023
@dtolnay
Copy link
Member Author

dtolnay commented Aug 26, 2023

FWIW for my own use case in https://github.com/dtolnay/trybuild which motivated --keep-going, I don't need -k and wouldn't use it.

@weihanglo weihanglo added A-cli Area: Command-line interface, option parsing, etc. S-needs-team-input Status: Needs input from team on whether/how to proceed. E-easy Experience: Easy and removed S-triage Status: This issue is waiting on initial triage. labels Aug 26, 2023
@joshtriplett
Copy link
Member

One option would be to go ahead and add this, on the theory that people may want it. Another would be to let people use --keep-going for a while, and see if it gets used manually (rather than by other tools) often enough to warrant a short option.

@epage
Copy link
Contributor

epage commented Aug 27, 2023

I lean towards the latter.

@joshtriplett
Copy link
Member

Likewise.

@after-ephemera
Copy link

Hi team, have we been able to collect any data on whether the full --keep-going flag has been used manually at this point?

@dtolnay
Copy link
Member Author

dtolnay commented Jan 8, 2024

I have been happily using --keep-going in the trybuild crate for 9 months to great effect, which was my original motivation for contributing this flag. So far I have not had any occasion to use this flag in interactive command-line usage, despite the existence of the flag being clearly well-known to me.

I think I would close this issue, and just rely on anyone for whom this flag appears commonly in their interactive workflow to make the case for a short flag in a separate issue, as they would for any other long-only flag that has been stable for longer.

@dtolnay dtolnay closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` E-easy Experience: Easy S-needs-team-input Status: Needs input from team on whether/how to proceed.
Projects
None yet
Development

No branches or pull requests

5 participants