Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"cargo publish" should error if there are path overrides #2489

Open
erickt opened this issue Mar 16, 2016 · 6 comments
Open

"cargo publish" should error if there are path overrides #2489

erickt opened this issue Mar 16, 2016 · 6 comments
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself. A-overrides Area: general issues with overriding dependencies (patch, replace, paths) Command-publish S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing.

Comments

@erickt
Copy link
Contributor

erickt commented Mar 16, 2016

This might result in builds that succeed on the local machine, but fail when someone else tries to build the crate.

@alexcrichton
Copy link
Member

Indeed! Or it should just ignore them.

@eminence
Copy link
Contributor

Triage: I tested this scenario today and it seems like path dependencies are ignored during publish (meaning cargo will pull that dependency from the registry, not from the path in Cargo.toml). Same with patch overrides. I wasn't able to immeditally find the commit that implemented this, though.

@ehuss
Copy link
Contributor

ehuss commented Nov 23, 2022

@eminence I believe this is referring to paths overrides, which are defined in config.toml. The package verification step still uses those overrides, when it probably shouldn't.

@eminence
Copy link
Contributor

Ahyes, I see. Thank you @ehuss for that clarification.

@weihanglo weihanglo added A-overrides Area: general issues with overriding dependencies (patch, replace, paths) S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing. labels May 30, 2023
@Rustin170506
Copy link
Member

@weihanglo Is this issue S-accepted ? It looks interesting. Can I pick it up and try to improve it?

@weihanglo
Copy link
Member

It is S-needs-mentor, which means we may or may not have time mentoring and reviewing it. It might be okay as you're already familiar with the codebase.

@epage epage added the A-diagnostics Area: Error and warning messages generated by Cargo itself. label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself. A-overrides Area: general issues with overriding dependencies (patch, replace, paths) Command-publish S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing.
Projects
None yet
Development

No branches or pull requests

7 participants