Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression bug in workspaces handling #3698

Closed
nbaksalyar opened this issue Feb 14, 2017 · 5 comments
Closed

Possible regression bug in workspaces handling #3698

nbaksalyar opened this issue Feb 14, 2017 · 5 comments

Comments

@nbaksalyar
Copy link
Contributor

nbaksalyar commented Feb 14, 2017

Cargo/rustc behavior has changed from 1.14 to 1.15 when building libraries within workspaces.

E.g. here's the output for 1.14:

$ cargo build --release
Compiling safe_app v0.1.0
...
$ ls ../target/release/deps/
libsafe_app.so
libsafe_app.rlib
libsafe_app.a

And there's also libsafe_app.so in ../target/release.

Now, after I switch my toolchain to 1.15 in rustup, a hash is appended to output file names:

$ cargo build --release
Compiling safe_app v0.1.0
...
$ ls ../target/release/deps/
libsafe_app-98e60e5e55f57beb.so
libsafe_app-98e60e5e55f57beb.a
libsafe_app-98e60e5e55f57beb.rlib

And, more importantly, there's nothing in the ../target/release/ directory.

At the same time it still works correctly for non-workspaced projects and I can find the library file copied to the target/release/ dir.

This breaks continuous integration scripts on 1.15 for projects that use workspaces.

@matklad
Copy link
Member

matklad commented Feb 14, 2017

And there's also libsafe_app.so in target/release`.

Do you mean ../target/release, or ./target? If there were two different target directories, than that means that some package was actually outside the workspace.

@nbaksalyar
Copy link
Contributor Author

nbaksalyar commented Feb 14, 2017

@matklad yep, clarified that - thanks! It's ../target/release (there's no separate target dir)

@alexcrichton
Copy link
Member

Ah yes I think this is a dupe of #3674, fixed in #3478 and caused by #3221.

Could you test beta to make sure it works?

@nbaksalyar
Copy link
Contributor Author

Could you test beta to make sure it works?

Yes, it works! Thanks! :)

@alexcrichton
Copy link
Member

Ok, thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants