Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -Ctarget-cpu=native during cargo install #4150

Closed
Manishearth opened this issue Jun 9, 2017 · 9 comments
Closed

Pass -Ctarget-cpu=native during cargo install #4150

Manishearth opened this issue Jun 9, 2017 · 9 comments

Comments

@Manishearth
Copy link
Member

This lets LLVM assume that the binary will be run on a machine with all the features as the host machine (and thus optimize more e.g. with better SIMD/AVX). Which is true for cargo install, and we should pass it by default, perhaps with a flag to turn it off.

cc @rust-lang/cargo

@joshtriplett
Copy link
Member

We can't automatically make this assumption; people do use cargo install as part of packaging systems, too.

@Nemo157
Copy link
Member

Nemo157 commented Jan 4, 2019

Based on the discussion in the linked PR and @joshtriplett's comment, should this be closed as "won't fix"?

@alexcrichton
Copy link
Member

I think so!

@joshtriplett
Copy link
Member

We could reasonably pass this by default for build scripts, if we want to, though.

@Rudxain
Copy link

Rudxain commented Sep 9, 2022

This should be closed as "not-planned", not "completed". This may be misleading

@Nemo157
Copy link
Member

Nemo157 commented Sep 9, 2022

That is a github bug, there was no such thing as a close reason when this issue was closed and github assigned "completed" to all previously closed issues.

@weihanglo
Copy link
Member

They provide a way to close it again as not planned. Lemme try.

image

@weihanglo weihanglo closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2022
@Rudxain
Copy link

Rudxain commented Sep 12, 2022

That is a github bug, there was no such thing as a close reason when this issue was closed and github assigned "completed" to all previously closed issues.

I'm sorry for my ignorance. Thank you for clarifying this

Rudxain added a commit to Rudxain/dotfiles that referenced this issue May 22, 2024
@Rudxain
Copy link

Rudxain commented May 23, 2024

What about a new sub-cmd? (we can bike-shed the name later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants