-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass -Ctarget-cpu=native during cargo install #4150
Comments
We can't automatically make this assumption; people do use |
Based on the discussion in the linked PR and @joshtriplett's comment, should this be closed as "won't fix"? |
I think so! |
We could reasonably pass this by default for build scripts, if we want to, though. |
This should be closed as "not-planned", not "completed". This may be misleading |
That is a github bug, there was no such thing as a close reason when this issue was closed and github assigned "completed" to all previously closed issues. |
I'm sorry for my ignorance. Thank you for clarifying this |
What about a new sub-cmd? (we can bike-shed the name later) |
This lets LLVM assume that the binary will be run on a machine with all the features as the host machine (and thus optimize more e.g. with better SIMD/AVX). Which is true for
cargo install
, and we should pass it by default, perhaps with a flag to turn it off.cc @rust-lang/cargo
The text was updated successfully, but these errors were encountered: