Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should cargo fix --prepare-for 2018 fix unrelated warnings? #5844

Closed
Manishearth opened this issue Jul 31, 2018 · 1 comment
Closed

Should cargo fix --prepare-for 2018 fix unrelated warnings? #5844

Manishearth opened this issue Jul 31, 2018 · 1 comment

Comments

@Manishearth
Copy link
Member

If you pass this crate through cargo fix --prepare-for 2018

fn main() {
    let x = 1;
}

it fixes to:

fn main() {
    let _x = 1;
}

Should we be fixing non-edition warnings at all? These are marked applicable so we should be able to trust them, but perhaps we should exclude them for the sake of doing the minimum necessary?

cc @killercup @alexcrichton

@alexcrichton
Copy link
Member

I believe this is covered by #5738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants