Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace: Inherit project-oriented Cargo.toml attributes #6828

Closed
behnam opened this issue Apr 8, 2019 · 3 comments
Closed

Workspace: Inherit project-oriented Cargo.toml attributes #6828

behnam opened this issue Apr 8, 2019 · 3 comments
Labels
A-workspaces Area: workspaces C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`

Comments

@behnam
Copy link
Contributor

behnam commented Apr 8, 2019

Describe the problem you are trying to solve

Having a workspace set up for multiple related crates, there's usually a big chunk of Cargo.toml attributes which need to be copy-pasted across all instances.

For example, in UNIC, we have (at least) these lines in all (published) Cargo.toml files:

[badges]
maintenance = { status = "actively-developed" }
is-it-maintained-issue-resolution = { repository = "open-i18n/rust-unic" }
is-it-maintained-open-issues = { repository = "open-i18n/rust-unic" }
appveyor = { repository = "open-i18n/rust-unic", branch = "master", service = "github" }
travis-ci = { repository = "open-i18n/rust-unic", branch = "master" }

Most of such properties are project-specific, but not crate-specific. For example, an indicator of that would be the fact that the share the same repository value.

Describe the solution you'd like

It would be great if we could actually have such project-oriented attributes inherit from the workspace's main Cargo.toml, and do no need to maintain copies of them.

Notes

Wdyt?

@behnam behnam added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Apr 8, 2019
@ehuss ehuss added the A-workspaces Area: workspaces label Apr 12, 2019
@alexcrichton
Copy link
Member

For anyone interested in this issue I've posted an RFC which I think will help resolve this. Feedback on the RFC would be most welcome!

@Veetaha
Copy link

Veetaha commented Sep 16, 2022

@alexcrichton isn't this superseded by #8415 (comment)? If so, we can close this

@epage
Copy link
Contributor

epage commented Sep 16, 2022

Workspace inheritance is stablized and will be released in 1.64.

This issue specifically mentions [badge] which was not included but it is no longer used on at least crates.io.

I lean towards going ahead and closing this. If there is a reason to re-evaluate this, let us know!

@epage epage closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-workspaces Area: workspaces C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
Projects
None yet
Development

No branches or pull requests

5 participants