Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rustc-link-args in order to properly pass -pthread and flags #7796

Closed
infinity0 opened this issue Jan 14, 2020 · 3 comments
Closed

Support rustc-link-args in order to properly pass -pthread and flags #7796

infinity0 opened this issue Jan 14, 2020 · 3 comments
Labels
A-build-scripts Area: build.rs scripts C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` T-cargo Team: Cargo

Comments

@infinity0
Copy link
Contributor

On rust-lang/rust#62117 it was discovered that certain C/C++ dependencies need to be linked with -pthread instead of -lpthread on certain platforms such as riscv64 and some arm cases.

Currently there is no way for a build.rs script to express this however. The closest thing is rustc-dylib-link-args which only applies when building a cdylib.
@infinity0 infinity0 added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Jan 14, 2020
@infinity0 infinity0 mentioned this issue Jan 14, 2020
Closed
@joshtriplett
Copy link
Member

#7811

@joshtriplett joshtriplett added the T-cargo Team: Cargo label Jan 18, 2020
@ehuss ehuss added the A-build-scripts Area: build.rs scripts label Feb 2, 2020
@XieJiSS
Copy link

XieJiSS commented Dec 11, 2021

Just a reminder: This should be closed by #8441

@ehuss
Copy link
Contributor

ehuss commented Dec 11, 2021

Closing, as it does sound like this is resolved, at least when using build scripts (docs).

@ehuss ehuss closed this as completed Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build-scripts Area: build.rs scripts C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` T-cargo Team: Cargo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ehuss @infinity0 @joshtriplett @XieJiSS