Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing output when checking crate with build script (?) #7921

Open
RalfJung opened this issue Feb 22, 2020 · 0 comments
Open

Confusing output when checking crate with build script (?) #7921

RalfJung opened this issue Feb 22, 2020 · 0 comments
Labels
A-console-output Area: Terminal output, colors, progress bar, etc. C-bug Category: bug S-triage Status: This issue is waiting on initial triage.

Comments

@RalfJung
Copy link
Member

Problem

Running ./x.py check src/librustc_mir in the rustc repo produces output like this:

Checking std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
   Compiling cc v1.0.50
    Checking core v0.0.0 (/home/r/src/rust/rustc/src/libcore)
   Compiling libc v0.2.66
   Compiling autocfg v0.1.7
   Compiling std v0.0.0 (/home/r/src/rust/rustc/src/libstd)
   Compiling hashbrown v0.6.2
   Compiling compiler_builtins v0.1.25
   Compiling backtrace-sys v0.1.32
   Compiling unwind v0.0.0 (/home/r/src/rust/rustc/src/libunwind)
    Checking rustc-std-workspace-core v1.99.0 (/home/r/src/rust/rustc/src/tools/rustc-std-workspace-core)
    Checking cfg-if v0.1.10
    Checking alloc v0.0.0 (/home/r/src/rust/rustc/src/liballoc)
    Checking rustc-demangle v0.1.16
    Checking panic_abort v0.0.0 (/home/r/src/rust/rustc/src/libpanic_abort)
    Checking backtrace v0.3.44
    Checking rustc-std-workspace-alloc v1.99.0 (/home/r/src/rust/rustc/src/tools/rustc-std-workspace-alloc)
    Checking panic_unwind v0.0.0 (/home/r/src/rust/rustc/src/libpanic_unwind)
    Checking rustc-std-workspace-std v1.99.0 (/home/r/src/rust/rustc/src/tools/rustc-std-workspace-std)
    Checking term v0.0.0 (/home/r/src/rust/rustc/src/libterm)
    Checking proc_macro v0.0.0 (/home/r/src/rust/rustc/src/libproc_macro)
    Checking unicode-width v0.1.6
    Checking getopts v0.2.21
    Checking test v0.0.0 (/home/r/src/rust/rustc/src/libtest)
    Finished release [optimized + debuginfo] target(s) in 28.53s

Notice that it says "Compiling std", but "Checking core". That seems very odd.
With some extra levels of verbosity, I see the expected --emit=dep-info,metadata, so it looks like it is actually just checking std and not building it.

Possible Solution(s)

My guess is that the key difference between "core" and "std" here is that "std" has a build script. Of course it needs to actually compile the build script, not just check it. But describing that as "Compiling std" is pretty confusing, given that the actual library is not being built, just checked.

@RalfJung RalfJung added the C-bug Category: bug label Feb 22, 2020
@ehuss ehuss added the A-console-output Area: Terminal output, colors, progress bar, etc. label Feb 25, 2020
@epage epage added the S-triage Status: This issue is waiting on initial triage. label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-console-output Area: Terminal output, colors, progress bar, etc. C-bug Category: bug S-triage Status: This issue is waiting on initial triage.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants