Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme says cargo just needs git to build on windows... #8190

Closed
gilescope opened this issue May 1, 2020 · 1 comment
Closed

Readme says cargo just needs git to build on windows... #8190

gilescope opened this issue May 1, 2020 · 1 comment
Labels
A-cargo-api Area: cargo-the-library API and internal code issues C-bug Category: bug O-windows OS: Windows

Comments

@gilescope
Copy link
Contributor

Problem

Quite a few crates use cargo as a dependency. As such it would be great if cargo built on windows easily (we use the msvc toolchain).

But when you build something depending on the cargo crate in windows 10 you get:

Caused by:
process didn't exit successfully: C:\DEVELO~1\Temp\cargo-installR7sgTS\release\build\libz-sys-c5dba26ec57df1d6\build-script-build (exit code: 1)
--- stdout
cargo:rerun-if-env-changed=LIBZ_SYS_STATIC
cargo:rerun-if-changed=build.rs
note, vcpkg did not find zlib: Aborted because VCPKGRS_DYNAMIC is not set

Steps to reproduce

  1. cargo install cargo-local-registry

Should we be manually building vcpkg and then downloading some packages for it? It's not clear how we should be building this in windows.

Possible Solutions
A pure rust zip crate instead as a dependency is the long term solution.
Give additional guidance on the readme as to how to build on windows.

@gilescope gilescope added the C-bug Category: bug label May 1, 2020
@ehuss ehuss added A-cargo-api Area: cargo-the-library API and internal code issues O-windows OS: Windows labels May 23, 2020
@weihanglo
Copy link
Member

I have the impression that #11030 expands the requirements well, so we may close this issue at this moment. Thank you!

I do agree that pure Rust crate sounds great but it is really a long long long term solution 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cargo-api Area: cargo-the-library API and internal code issues C-bug Category: bug O-windows OS: Windows
Projects
None yet
Development

No branches or pull requests

3 participants