Disable custom_target::custom_bin_target on windows-gnu #12763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
weihanglo
approved these changes
Oct 2, 2023
|
Looks good! @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2023
Update cargo 9 commits in 59596f0f31a94fde48b5aa7e945cd0b7ceca9620..794d0a82547f3081044c0aca7b6083733ce51344 2023-09-29 19:29:17 +0000 to 2023-10-03 23:19:33 +0000 - Prep for automating MSRV management (rust-lang/cargo#12767) - chore(deps): update rust crate itertools to 0.11.0 (rust-lang/cargo#12759) - fix bug: corruption when cargo killed while writing (rust-lang/cargo#12744) - Disable custom_target::custom_bin_target on windows-gnu (rust-lang/cargo#12763) - chore(deps): update compatible (rust-lang/cargo#12757) - Add more missing `strip` info to docs. (rust-lang/cargo#12754) - chore(deps): update actions/checkout action to v4 (rust-lang/cargo#12762) - chore(deps): update rust crate cargo_metadata to 0.18.0 (rust-lang/cargo#12758) - fix(test): Add back in newlines to diffs (rust-lang/cargo#12753) r? ghost
bors
added a commit
that referenced
this pull request
Nov 14, 2023
Ignore changing_spec_relearns_crate_types on windows-gnu This disables the `custom_target::changing_spec_relearns_crate_types` on windows-gnu targets for the same reason as #12763. The update to LLVM 17 has started to cause lld to crash when using a custom target. cc rust-lang/rust#115985 I surveyed the rest of the testsuite, and I don't see any other tests that perform linking with custom targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
custom_target::custom_bin_targettest has been crashing frequently in CI on the x86_64-pc-windows-gnu target since the last LLVM 17 update. This disables the test to reduce the disruption in CI. The issue is being tracked in rust-lang/rust#115985.