From 6cbff0702f20af6abac27597ec2354f89d986d7c Mon Sep 17 00:00:00 2001 From: Ed Page Date: Wed, 12 Jun 2024 09:45:04 -0500 Subject: [PATCH 1/5] docs(contrib): Clarify labels reserved for the Cargo team to set --- src/doc/contrib/src/issues.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/doc/contrib/src/issues.md b/src/doc/contrib/src/issues.md index c77c083b204..67e4c45f175 100644 --- a/src/doc/contrib/src/issues.md +++ b/src/doc/contrib/src/issues.md @@ -225,9 +225,9 @@ There are several things to consider when triaging an issue: needs to discuss whether or not to proceed and what needs to be done to address the issue. * [S-needs-mentor] --- This is something the Cargo team wants to address, - but does not currently have the capacity to help with reviewing. + but does not currently have the capacity to help with reviewing. **(reserved for Cargo team)** * [S-accepted] --- This is something that clearly needs to be addressed, and - a Cargo team member has volunteered to help review. + a Cargo team member has volunteered to help review. **(reserved for Cargo team)** Anyone is welcome to help with the triaging process. You can help with reproducing issues, checking for duplicates, gathering more information from From faf2d6acc111dee603e0248faa2bcb067dd76a8e Mon Sep 17 00:00:00 2001 From: Ed Page Date: Wed, 12 Jun 2024 09:55:53 -0500 Subject: [PATCH 2/5] docs(contrib): Focus duplicates on root cause and not solutions --- src/doc/contrib/src/issues.md | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/doc/contrib/src/issues.md b/src/doc/contrib/src/issues.md index 67e4c45f175..8385fa7489a 100644 --- a/src/doc/contrib/src/issues.md +++ b/src/doc/contrib/src/issues.md @@ -197,10 +197,13 @@ issues have not yet been triaged. There are several things to consider when triaging an issue: * Is this a duplicate? Search the issue tracker (including closed issues) to - see if there is something similar or identical to what is reported. If it is - obviously a duplicate, write a comment that it is a duplicate of the other - issue, and close the issue. If it isn't obvious that it is a duplicate, - leave a comment asking the author if the other issue covers what they reported. + see if there is an issue with a similar or identical root cause to what is reported. + We generally focus issues around root causes so alternative solutions can be + discussed and evaluated together. + If it is obviously a duplicate, write a comment that it is a duplicate of the + other issue, and close the issue. + If it isn't obvious that it is a duplicate, leave a comment asking the author + if the other issue covers what they reported. * For a bug, check if the report contains enough information to reproduce it. If you can't reproduce it, solicit more information from the author to From 2dc4a8e6f38e9515f070fdc5c0097361c7e0ab52 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Wed, 12 Jun 2024 10:03:37 -0500 Subject: [PATCH 3/5] docs(contrib): Re-order labels according to stages --- src/doc/contrib/src/issues.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/doc/contrib/src/issues.md b/src/doc/contrib/src/issues.md index 8385fa7489a..1592cef34a3 100644 --- a/src/doc/contrib/src/issues.md +++ b/src/doc/contrib/src/issues.md @@ -220,13 +220,13 @@ There are several things to consider when triaging an issue: * Assuming the issue looks valid, remove the [S-triage] label and move it onto a new status: - * [S-needs-rfc] --- This is a large feature request that will require a - public design process. - * [S-needs-design] --- The resolution of the issue or small feature request - will need more work to come up with the appropriate design. * [S-needs-team-input] --- The next steps are not clear, and the Cargo team needs to discuss whether or not to proceed and what needs to be done to address the issue. + * [S-needs-design] --- The resolution of the issue or small feature request + will need more work to come up with the appropriate design. + * [S-needs-rfc] --- This is a large feature request that will require a + public design process. * [S-needs-mentor] --- This is something the Cargo team wants to address, but does not currently have the capacity to help with reviewing. **(reserved for Cargo team)** * [S-accepted] --- This is something that clearly needs to be addressed, and From d3184540b7d9e55e10df8639efa0672e71837031 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Wed, 12 Jun 2024 10:05:14 -0500 Subject: [PATCH 4/5] docs(contrib): Clarify steps for S-needs-rfc --- src/doc/contrib/src/issues.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/doc/contrib/src/issues.md b/src/doc/contrib/src/issues.md index 1592cef34a3..4e5db29cf64 100644 --- a/src/doc/contrib/src/issues.md +++ b/src/doc/contrib/src/issues.md @@ -155,8 +155,9 @@ different steps, or in rare cases have multiple statuses. * **[S-needs-rfc]** --- Needs an [RFC] before this can make more progress. Anyone is welcome to help at this stage, but it should be clear that it is - not yet accepted. However, this should only be tagged for changes that are - somewhat likely to be accepted. + not yet accepted. + See [Before creating an RFC](https://github.com/rust-lang/rfcs?tab=readme-ov-file#before-creating-an-rfc) + for next steps. * **[S-needs-mentor]** --- Needs a Cargo team member to commit to helping and reviewing. From 390accfbda6dfbfd96b854f78ce372d829707d84 Mon Sep 17 00:00:00 2001 From: Ed Page Date: Thu, 13 Jun 2024 12:47:55 -0500 Subject: [PATCH 5/5] docs(contrib): Clarify that S- label switching is 'atomic' --- src/doc/contrib/src/issues.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/doc/contrib/src/issues.md b/src/doc/contrib/src/issues.md index 4e5db29cf64..7bb0a6fa2bf 100644 --- a/src/doc/contrib/src/issues.md +++ b/src/doc/contrib/src/issues.md @@ -218,8 +218,7 @@ There are several things to consider when triaging an issue: prefixed labels (depending on if it is a regression in an already released stable release, or it is in nightly). -* Assuming the issue looks valid, remove the [S-triage] label and move it onto - a new status: +* Assuming the issue looks valid, switch the [S-triage] label for one of the following: * [S-needs-team-input] --- The next steps are not clear, and the Cargo team needs to discuss whether or not to proceed and what needs to be done to