Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error-chain errors. #4090

Merged
merged 12 commits into from
May 31, 2017
Merged

Add error-chain errors. #4090

merged 12 commits into from
May 31, 2017

Commits on May 24, 2017

  1. Add error-chain errors

    Convert CargoResult, CargoError into an implementation provided by error-chain. The previous is_human machinery is mostly removed; now errors are displayed unless of the Internal kind, verbose mode will print all errors.
    jluner committed May 24, 2017
    Configuration menu
    Copy the full SHA
    b1b6973 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2017

  1. Add error-chain errors

    Convert CargoResult, CargoError into an implementation provided by error-chain. The previous is_human machinery is mostly removed; now errors are displayed unless of the Internal kind, verbose mode will print all errors.
    jluner committed May 25, 2017
    Configuration menu
    Copy the full SHA
    e95044e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d7ac0d View commit details
    Browse the repository at this point in the history
  3. Addresses review comments

    * rebased
    * removed `human` (deferring removing `internal` to a later PR)
    * cargo_test.rs - fails on other error kinds
    * unnecessary `map_err(CargoError::from)` removed
    * fold NetworkError entirely into CargoError
    * added justification comment for `extend_lifetime`
    * various formatting goofs
    
    The following tests are currently failing:
    * `http_auth_offered`
    * `custom_build_script_failed`
    * `build_deps_for_the_right_arch`
    * `dep_with_bad_submodule`
    * `update_with_shared_deps`
    * `finds_author_email`
    * `finds_author_user`
    * `finds_author_user_escaped`
    * `finds_author_username`
    * `finds_git_author`
    * `exit_code`
    jluner committed May 25, 2017
    Configuration menu
    Copy the full SHA
    c7de485 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2017

  1. Fix failing tests

    jluner committed May 27, 2017
    Configuration menu
    Copy the full SHA
    2f3955a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e9161b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d121e05 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2017

  1. Configuration menu
    Copy the full SHA
    3c91570 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84667a1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7f6dbc1 View commit details
    Browse the repository at this point in the history
  4. Restore macro_use

    jluner committed May 28, 2017
    Configuration menu
    Copy the full SHA
    68f5584 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2017

  1. Fixes review comments

    Fix some formatting items.
    Changes Internal error kind to preserve the original error.
    Changes network retry logic to inspect full error chain for spurious
    errors.
    jluner committed May 31, 2017
    Configuration menu
    Copy the full SHA
    def249f View commit details
    Browse the repository at this point in the history