-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error-chain errors. #4090
Merged
Merged
Add error-chain errors. #4090
Commits on May 24, 2017
-
Convert CargoResult, CargoError into an implementation provided by error-chain. The previous is_human machinery is mostly removed; now errors are displayed unless of the Internal kind, verbose mode will print all errors.
Configuration menu - View commit details
-
Copy full SHA for b1b6973 - Browse repository at this point
Copy the full SHA b1b6973View commit details
Commits on May 25, 2017
-
Convert CargoResult, CargoError into an implementation provided by error-chain. The previous is_human machinery is mostly removed; now errors are displayed unless of the Internal kind, verbose mode will print all errors.
Configuration menu - View commit details
-
Copy full SHA for e95044e - Browse repository at this point
Copy the full SHA e95044eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d7ac0d - Browse repository at this point
Copy the full SHA 5d7ac0dView commit details -
* rebased * removed `human` (deferring removing `internal` to a later PR) * cargo_test.rs - fails on other error kinds * unnecessary `map_err(CargoError::from)` removed * fold NetworkError entirely into CargoError * added justification comment for `extend_lifetime` * various formatting goofs The following tests are currently failing: * `http_auth_offered` * `custom_build_script_failed` * `build_deps_for_the_right_arch` * `dep_with_bad_submodule` * `update_with_shared_deps` * `finds_author_email` * `finds_author_user` * `finds_author_user_escaped` * `finds_author_username` * `finds_git_author` * `exit_code`
Configuration menu - View commit details
-
Copy full SHA for c7de485 - Browse repository at this point
Copy the full SHA c7de485View commit details
Commits on May 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 2f3955a - Browse repository at this point
Copy the full SHA 2f3955aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e9161b - Browse repository at this point
Copy the full SHA 6e9161bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d121e05 - Browse repository at this point
Copy the full SHA d121e05View commit details
Commits on May 28, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 3c91570 - Browse repository at this point
Copy the full SHA 3c91570View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84667a1 - Browse repository at this point
Copy the full SHA 84667a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f6dbc1 - Browse repository at this point
Copy the full SHA 7f6dbc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68f5584 - Browse repository at this point
Copy the full SHA 68f5584View commit details
Commits on May 31, 2017
-
Fix some formatting items. Changes Internal error kind to preserve the original error. Changes network retry logic to inspect full error chain for spurious errors.
Configuration menu - View commit details
-
Copy full SHA for def249f - Browse repository at this point
Copy the full SHA def249fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.