-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename cargo-update
to cargo-updat
#413
Conversation
Any executable with the substring "update" on windows is subject to requiring privilege escalation. For now we just rename the actual executable to `cargo-updat` but rename all usage of it so that it's not actually visible. Closes rust-lang#393
How about another word sync/upgrade/pull ? |
You can add a manifest instead of renaming, e.g. see https://github.com/0install/0install/blob/master/ocaml/0install.exe.manifest. |
@whitequark, rustc itself started doing this as part of rust-lang/rust#10878, but it was reverted in rust-lang/rust#11221. The tracking issue for doing this is rust-lang/rust#11207. Adding a manifest should be part of rustc, not cargo @Locke23rus, we could, but I think that "update" is really the right word for this and the ergonomics are not compromised here at all, so it's not too much of a worry. |
I'm pro renaming it to something that is an actual word as well. I like the suggestions of @Locke23rus. |
https://github.com/rust-lang/cargo/pull/413/files#diff-847cd20bb1f94e626f11c2eb7358f4beR192
|
Just rename the binary to Edit: I will admit that when I first read the subject I thought alexcrichton had lost his mind and checked my calendar to make sure it's not April. It perhaps might confuse future code contributors if you name it |
I'm going to take a different strategy. |
Any executable with the substring "update" on windows is subject to requiring
privilege escalation. For now we just rename the actual executable to
cargo-updat
but rename all usage of it so that it's not actually visible.Closes #393