Bail if targets require nonexistent feature. #4874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bin-, bench-, test- and example-targets may specify a set of required features. Before this commit, it was possible to specify features not declared in [features], which could be confusing in case of typos. This is now a hard error during manifest-parsing. Fixes rust-lang#4854
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Well I just realized this is simply wrong. Features can be given as |
bors
added a commit
that referenced
this pull request
Jul 28, 2020
…huss Check manifest for requiring nonexistent features Fixes #4854: Examples requiring a nonexistent feature should be an error Thanks @lukaslueg with his #4874 for the inspiration!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bin-, bench-, test- and example-targets may specify a set of required
features. Before this commit, it was possible to specify features not
declared in [features], which could be confusing in case of typos. This
is now a hard error during manifest-parsing.
Fixes #4854