Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[aapcs_on_arm] is applied to two functions with no floating point #373

Closed
AaronKutch opened this issue Aug 16, 2020 · 2 comments · Fixed by #384
Closed

#[aapcs_on_arm] is applied to two functions with no floating point #373

AaronKutch opened this issue Aug 16, 2020 · 2 comments · Fixed by #384

Comments

@AaronKutch
Copy link
Contributor

In PR #332 and in my upcoming PR for fixing issue #367, I have noticed two functions, __multi3 and __divmoddi4, which have #[aapcs_on_arm] for no apparent reason. Amanieu said that all it does is force soft-float convention even on hard-float targets. I checked the arm part of compiler-rt and don't see anything unusual with those functions. Those two functions are the only non-floating-point related functions with #[aapcs_on_arm] on them. Can I remove those two instances of #[aapcs_on_arm] in my two PRs?
@alexcrichton
Copy link
Member

These are likely a mistake. IIRC we copied this mostly from compiler-rt, but even there it may have been a mistake or we mistakenly copied something over. Should be fine to fix!

@AaronKutch
Copy link
Contributor Author

Ok just double checking, I will close this issue once both are fixed

@AaronKutch AaronKutch mentioned this issue Oct 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overhaul split integer handling and fix numerous issues AaronKutch/compiler-builtins
2 participants
@alexcrichton @AaronKutch