Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u128_divide_sparc get build into rust stdlib for x86_64-pc-windows-msvc target #422

Closed
klensy opened this issue May 30, 2021 · 2 comments · Fixed by #424
Closed

u128_divide_sparc get build into rust stdlib for x86_64-pc-windows-msvc target #422

klensy opened this issue May 30, 2021 · 2 comments · Fixed by #424

Comments

@klensy
Copy link
Contributor

klensy commented May 30, 2021

Checked exported symbols for std-[hash].dll for current stable and nightly and found _ZN17compiler_builtins3int19specialized_div_rem8delegate17u128_divide_sparc17hd4dfbbe4547e607fE inside, i guess #393 is source of this.

I guess sparc related functions shouldn't get build into other os stdlib.

@Amanieu
Copy link
Member

Amanieu commented May 31, 2021

cc @AaronKutch

@AaronKutch
Copy link
Contributor

There are a number of hidden function specializations (another example is usize_leading_zeros_riscv) which are public so that they can get tested by the test suite which is in a separate crate. The CI does not have SPARC or RISCV which is why these are always enabled. I think I once wanted to make a feature flag for making these functions public, that would only be enabled by the testcrate. I can't remember why I never did it, I will open a PR and try doing it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants