Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PredicateKind in favor of only Binder<PredicateAtom> #397

Closed
1 of 3 tasks
jackh726 opened this issue Jan 4, 2021 · 3 comments
Closed
1 of 3 tasks

Remove PredicateKind in favor of only Binder<PredicateAtom> #397

jackh726 opened this issue Jan 4, 2021 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@jackh726
Copy link
Member

jackh726 commented Jan 4, 2021

Proposal

In #285 it was proposed, and in implemented in rust-lang/rust#73503, to change Predicate to move the Binder(s) out of the variants and into an outer PredicateKind::ForAll, with an additional no-binding PredicateKind::Implies. The overall motivation here was based around 1) matching Chalk more closely and 2) enabling GATs. In Chalk, we've actually since removed the Implies variant (rust-lang/chalk#514). Additionally, in rust-lang/rust#76814, I've found that the ForAll/Implies split actually does make some things more complicated w.r.t. supertrait enumeration and such.

This proposal essentially aims to effectively remove the distinction between ForAll/Implies and make Predicate just container a Binder<PredicateAtom> always. This again more closely matches current Chalk.

This is already implemented in rust-lang/rust#80679 (modulo a bug).

Mentors or Reviewers

@lcnr and @nikomatsakis to review

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@jackh726 jackh726 added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Jan 4, 2021
@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2021

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jan 4, 2021
@nikomatsakis
Copy link
Contributor

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jan 6, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 7, 2021
@jackh726
Copy link
Member Author

The PR for this has been merged and this issue can be closed.

@jackh726 jackh726 added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jan 19, 2021
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jan 19, 2021
@jackh726 jackh726 removed the to-announce Announce this issue on triage meeting label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nikomatsakis @apiraino @jackh726 @rustbot