-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tier 3 target proposal: x86_64-unknown-none (freestanding/bare-metal x86-64) #462
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. cc @rust-lang/compiler @rust-lang/compiler-contributors |
(Fixed the issue title, and the Zulip stream link.) |
@rustbot second |
@rustbot label -final-comment-period +major-change-accepted |
@joshtriplett , how can I help get this to Tier 2? |
@bstrie I think it needs a combination of an MCP that documents the target meeting the tier 2 requirements, and a draft PR to rust-lang/rust CI adding a build of it. |
This compiler MCP proposes a new target,
x86_64-unknown-none
, for standaloneor "freestanding" x86-64 binaries with no operating system, using
ELF as the
object format. This target is intended for firmware, kernels, modules, and
other software running without an operating system.
This target will not provide an implementation of
std
, since that woulddepend on an operating system. This target will not provide a default
allocator, but can provide an implementation of
alloc
if the user of thetarget supplies an allocator.
The
x86_64-unknown-none
target will default to not allowing the use of anyvector or floating-point registers, because kernels, modules, and similar
software needs special care to use such registers. For instance, the Linux
kernel normally optimizes the entry and exit of the kernel by not saving and
restoring such registers; kernel code must explicitly request the use of such
registers before running code that uses them, and once requested, the kernel
must pay the additional overhead of saving the userspace registers to make way
for the kernel usage. Users of the
x86_64-unknown-none
target can still optinto the use of such registers via the
target-feature
mechanism, either foran entire program or for individual functions.
This target has a lot in common with
x86_64-unknown-none-linuxkernel
, but isintended to be general enough to work for any standalone/freestanding software
without requiring a specific target for each such environment.
I plan to work to get this target to tier 2, but the target needs to start out
at tier 3 and work its way up.
Checking off the target tier policy requirements for tier 3:
maintainers") on record to be CCed when issues arise regarding the target.
(The mechanism to track and CC such developers may evolve over time.)
Harald Hoyer harald@profian.com, https://github.com/haraldh
Mike Leany, https://github.com/mikeleany
target for the same CPU or OS as an existing Rust target should use the same
name for that CPU or OS. Targets should normally use the same names and
naming conventions as used elsewhere in the broader ecosystem beyond Rust
(such as in other toolchains), unless they have a very good reason to
diverge. Changing the name of a target can be highly disruptive, especially
once the target reaches a higher tier, so getting the name right is important
even for a tier 3 target.
absolutely necessary to maintain ecosystem compatibility. For example, if
the name of the target makes people extremely likely to form incorrect
beliefs about what it targets, the name should be changed or augmented to
disambiguate it.
Standalone targets have had a variety of names in different compilers. Some
compilers and embedded toolchains use the name
x86_64-unknown-elf
for suchtargets; in other toolchains, however,
-elf
may imply some minimal amount ofC library support. Rust has several standalone targets for various
architectures; RISC-V standalone targets use
none-elf
(e.g.riscv64gc-unknown-none-elf
), while most other standalone targets use justnone
(e.g.aarch64-unknown-none
,mipsel-unknown-none
) ornone
with anunrelated suffix for the ABI (e.g.
armv7r-none-eabi
,armv7a-none-eabi
).There is also precedent in the form of the
x86_64-unknown-none-linuxkernel
and
x86_64-unknown-none-hermitkernel
targets.This target proposal chooses to use
x86_64-unknown-none
, to avoid anyconnotations of library support, for consistency with more existing Rust
targets, and for consistency with the existing Rust
x86_64
kernel-specifictargets.
create legal issues or impose onerous legal terms for the Rust project or for
Rust developers or users.
✅ The
x86_64-unknown-none
target will not introduce any legal issues or newlegal terms.
✅ The
x86_64-unknown-none
target will not introduce any new dependencies orlicenses at all.
license (
MIT OR Apache-2.0
).✅ The pull requests adding and maintaining this target will of course be under
the standard Rust license.
host (even when supporting cross-compilation to the target) to depend
on any new dependency less permissive than the Rust licensing policy. This
applies whether the dependency is a Rust crate that would require adding
new license exceptions (as specified by the
tidy
tool in therust-lang/rust repository), or whether the dependency is a native library
or binary. In other words, the introduction of the target must not cause a
user installing or running a version of Rust or the Rust tools to be
subject to any new license requirements.
✅ This target adds no new dependencies of any kind.
rustc
orcargo
),those host tools must not depend on proprietary (non-FOSS) libraries, other
than ordinary runtime libraries supplied by the platform and commonly used
by other binaries built for the target. For instance,
rustc
built for thetarget may depend on a common proprietary C runtime library or console
output library, but must not depend on a proprietary code generation
library or code optimization library. Rust's license permits such
combinations, but the Rust project has no interest in maintaining such
combinations within the scope of Rust itself, even at tier 3.
✅ The target will not support host tools (nor does the target have any
proprietary libraries, or any libraries at all).
functional binary or library.
✅ The target will use a normal toolchain.
legal/licensing terms include but are not limited to: non-disclosure
requirements, non-compete requirements, contributor license agreements
(CLAs) or equivalent, "non-commercial"/"research-only"/etc terms,
requirements conditional on the employer or employment of any particular
Rust developers, revocable terms, any requirements that create liability
for the Rust project or its developers or users, or any requirements that
adversely affect the livelihood or prospects of the Rust project or its
developers or users.
✅ Understood.
binding agreement or estoppel by any party. If any member of an approving
Rust team serves as one of the maintainers of a target, or has any legal or
employment requirement (explicit or implicit) that might affect their
decisions regarding a target, they must recuse themselves from any approval
decisions regarding the target's tier status, though they may otherwise
participate in discussions.
cited in an explicit contract or work agreement (e.g. to implement or
maintain support for a target). This requirement exists to ensure that a
developer or team responsible for reviewing and approving a target does not
face any legal threats or obligations that would prevent them from freely
exercising their judgment in such approval, even if such judgment involves
subjective matters or goes beyond the letter of these requirements.
✅
I'm being paid to work on this target. I am not part of any approval decisions
regarding the tier status of the target.
as possible and appropriate (
core
for most targets,alloc
for targetsthat can support dynamic memory allocation,
std
for targets with anoperating system or equivalent layer of system-provided functionality), but
may leave some code unimplemented (either unavailable or stubbed out as
appropriate), whether because the target makes it impossible to implement or
challenging to implement. The authors of pull requests are not obligated to
avoid calling any portions of the standard library on the basis of a tier 3
target not implementing those portions.
✅ The
x86_64-unknown-none
target will implementcore
, and will supportusers using
alloc
with their own memory allocator. Thex86_64-unknown-none
target will not support
std
, and will not provide a default memory allocator.to build for the target, using cross-compilation if possible. If the target
supports running tests (even if they do not pass), the documentation must
explain how to run tests for the target, using emulation if possible or
dedicated hardware if necessary.
✅ Building for the target does not require any special considerations.
However, for completeness, the PR adding the target will provide documentation
to that effect.
The target does not support running tests.
other developers in the community, to maintain the target. In particular,
do not post comments (automated or manual) on a PR that derail or suggest a
block on the PR based on a tier 3 target. Do not send automated messages or
notifications (via any medium, including via
@
) to a PR author or othersinvolved with a PR regarding a tier 3 target, unless they have opted into
such messages.
an issue or PR are not considered a violation of this policy, within
reason. However, such messages (even on a separate repository) must not
generate notifications to anyone involved with a PR who has not requested
such notifications.
✅ Understood.
or tier 1 target, and must not knowingly break another tier 3 target without
approval of either the compiler team or the maintainers of the other tier 3
target.
such as variations of the same architecture with different features. Avoid
introducing unconditional uses of features that another variation of the
target may not have; use conditional compilation or runtime detection, as
appropriate, to let each target run code supported by that target.
✅ This target has some common functionality with the
x86_64-unknown-none-linuxkernel
target. After adding thex86_64-unknown-none
target, a follow-up PR may coordinate with themaintainers of the Linux kernel target to share this functionality. The
addition of
x86_64-unknown-none
will not knowingly break any other target.Work sponsored by Profian.
Process
The main points of the Major Change Process are as follows:
@rustbot second
.-C flag
, then full team check-off is required.@rfcbot fcp merge
on either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
The text was updated successfully, but these errors were encountered: